ananicy_cpp-rules -> ananicy-rules-cachyos_git: move to gitOverride #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRTitor
force-pushed
the
ananicy-cpp
branch
from
dbaa09f to
14f74e2
Compare
|
Should be ready to merge, I tried to move smaller packages to gitOverride before trying the big giant :) |
|
Oops! Something went wrong while caching this PR! Check the logs for more information. |
PedroHLC
requested changes
Oct 31, 2024
overlays/default.nix
Outdated
| @@ -83,7 +83,7 @@ in | |||
|
|
|||
| alacritty_git = callOverride ../pkgs/alacritty-git { }; | |||
|
|
|||
| ananicy-cpp-rules = final.callPackage ../pkgs/ananicy-cpp-rules { }; | |||
| ananicy-cpp-rules = callOverride ../pkgs/ananicy-cpp-rules { }; | |||
There was a problem hiding this comment.
Suffix it with _git here, and to be more explicit, it should be named ananicy-rules-cachyos_git. (nyxKey must be updated to match, no need to change the directory's name)
There was a problem hiding this comment.
Sure, I just wanted to make backwards-compatibility.
There was a problem hiding this comment.
Done, do you want me to maintain an alias?
It's packaged in nixpkgs, so we could just use an override. This is a breaking change.
JohnRTitor
force-pushed
the
ananicy-cpp
branch
from
14f74e2 to
d32e7c1
Compare
JohnRTitor
changed the title
PedroHLC
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐟 What?
🎣 Why?
🐳 Extras
Questions:
Are automatic update scripts affected by this? Let me know if I have to change something.