Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lix_git: init #837

Merged
merged 1 commit into from
Aug 26, 2024
Merged

lix_git: init #837

merged 1 commit into from
Aug 26, 2024

Conversation

dr460nf1r3
Copy link
Member

@dr460nf1r3 dr460nf1r3 commented Aug 16, 2024

🐟 What?

Added lix_git. That's what I'm currently using and I have to rebuild it very frequently, which takes ages on my machines.

🎣 Why?

Lix sparked my interest with a few things, so I'm willing to run it unstable 💥

🍥 Pending

  • Complain with linter;
  • Build the package.

🐳 Extras

A few things I'm excited about are particularly speed improvements and subtle QoL improvements such as multi-line log output.

Copy link
Contributor

Thank you for contributing to nyx! Please run nix fmt on your code before submitting a pull request. Afterwards, please force push your changes.

@dr460nf1r3 dr460nf1r3 added the needs-cache Needs to be pushed to Cachix label Aug 16, 2024
@dr460nf1r3
Copy link
Member Author

Another classic one of those:

image

@dr460nf1r3 dr460nf1r3 added needs-cache Needs to be pushed to Cachix and removed needs-cache Needs to be pushed to Cachix labels Aug 16, 2024
Copy link
Contributor

This PR has been built and cached successfully! All changed derivations have built successfully.

@github-actions github-actions bot added cached Built & Cached and removed needs-cache Needs to be pushed to Cachix labels Aug 16, 2024
Copy link
Member

@PedroHLC PedroHLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only accepting this if you rewrite it to not use their flake.

@dr460nf1r3 dr460nf1r3 added needs-cache Needs to be pushed to Cachix and removed cached Built & Cached labels Aug 16, 2024
Copy link
Contributor

This PR has been built and cached! However, it looks like some new failures have been introduced. Please check the logs for more information.

1 packages failed
  • lix_git

@github-actions github-actions bot added cached Built & Cached and removed needs-cache Needs to be pushed to Cachix labels Aug 16, 2024
@dr460nf1r3
Copy link
Member Author

Alright, I think this needs NixOS/nixpkgs#334269 to arrive in nixos-unstable to not fail during compilation:

       > ../tests/unit/libstore/protocol.hh:80:33: note: in definition of macro 'VERSIONED_CHARACTERIZATION_TEST'
       >    80 |         readTest(STEM, VERSION, VALUE); \
       >       |                                 ^~~~~
       > [330/486] Compiling C++ object tests/unit/liblixstore-tests.p/libstore_path.cc.o
       > [331/486] Compiling C++ object tests/unit/liblixexpr-tests.p/libexpr_trivial.cc.o
       > [332/486] Compiling C++ object tests/unit/liblixexpr-tests.p/libexpr_primops.cc.o
       > [333/486] Compiling C++ object tests/unit/liblixexpr-tests.p/libexpr_error_traces.cc.o
       > ninja: build stopped: subcommand failed.

Retrying once it is available.

@dr460nf1r3 dr460nf1r3 self-assigned this Aug 16, 2024
@PedroHLC PedroHLC removed the cached Built & Cached label Aug 16, 2024
@PedroHLC PedroHLC marked this pull request as draft August 17, 2024 17:00
@dr460nf1r3 dr460nf1r3 marked this pull request as ready for review August 26, 2024 18:12
@dr460nf1r3 dr460nf1r3 requested a review from PedroHLC August 26, 2024 18:13
@dr460nf1r3 dr460nf1r3 added the needs-cache Needs to be pushed to Cachix label Aug 26, 2024
Copy link
Contributor

This PR has been built and cached successfully! All changed derivations have built successfully.

@github-actions github-actions bot added cached Built & Cached and removed needs-cache Needs to be pushed to Cachix labels Aug 26, 2024
@PedroHLC PedroHLC merged commit e327b18 into main Aug 26, 2024
4 checks passed
@PedroHLC PedroHLC deleted the lix branch August 26, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cached Built & Cached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants