Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean-up error message if only 1 ancestor is valid for ontology term #637

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

nayib-jose-gloria
Copy link
Contributor

@nayib-jose-gloria nayib-jose-gloria commented Sep 20, 2023

Reason for Change

Changes

  • If we're only validating an ontology term against 1 allowed ancestor, print the ancestor term we're checking for in the error message as single term with single quotes instead of a list of 1.
  • For scenarios where a list of ancestors is expected, print as a single concatenated list rather than a list of lists

Testing

  • unit tests

Notes for Reviewer

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #637 (a87075a) into main (6cef195) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
+ Coverage   83.13%   83.15%   +0.01%     
==========================================
  Files          19       19              
  Lines        1696     1698       +2     
==========================================
+ Hits         1410     1412       +2     
  Misses        286      286              
Flag Coverage Δ
unittests 83.15% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cellxgene_schema_cli/cellxgene_schema/validate.py 93.72% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nayib-jose-gloria nayib-jose-gloria merged commit fcc77e3 into main Sep 20, 2023
8 checks passed
@nayib-jose-gloria nayib-jose-gloria deleted the nayib/514-fix-error-msg branch September 20, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants