Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(4.0): Load into memory if add_labels_file != None #636

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

Bento007
Copy link
Contributor

Reason for Change

Changes

  • Update read_h5ad to read into memory if to_memory is True
  • Add supporting unit tests

Testing

  • run the unit tests

Notes for Reviewer

- Update read_h5ad to read into memory if to_memory is True
- Add supporting unit tests
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #636 (5165cef) into main (1f482ae) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   83.23%   83.26%   +0.02%     
==========================================
  Files          19       19              
  Lines        1724     1727       +3     
==========================================
+ Hits         1435     1438       +3     
  Misses        289      289              
Flag Coverage Δ
unittests 83.26% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cellxgene_schema_cli/cellxgene_schema/utils.py 92.10% <100.00%> (+0.21%) ⬆️
cellxgene_schema_cli/cellxgene_schema/validate.py 93.61% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@nayib-jose-gloria nayib-jose-gloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Bento007 Bento007 merged commit 63fce72 into main Sep 21, 2023
8 checks passed
@Bento007 Bento007 deleted the tsmith/581-to-memory branch September 21, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants