Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add schema_reference field to uns during add-labels #626

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

nayib-jose-gloria
Copy link
Contributor

#518

Changes:

  • add schema_reference as reserved column in 'uns' for validation
  • populate schema_reference field during add-labels step

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #626 (7135a62) into main (ccad8d9) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
+ Coverage   83.02%   83.08%   +0.05%     
==========================================
  Files          19       19              
  Lines        1703     1709       +6     
==========================================
+ Hits         1414     1420       +6     
  Misses        289      289              
Flag Coverage Δ
unittests 83.08% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cellxgene_schema_cli/cellxgene_schema/env.py 100.00% <100.00%> (ø)
...lxgene_schema_cli/cellxgene_schema/write_labels.py 94.30% <100.00%> (+0.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@danieljhegeman danieljhegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayib-jose-gloria nayib-jose-gloria merged commit 1fba1b6 into main Sep 18, 2023
8 checks passed
@nayib-jose-gloria nayib-jose-gloria deleted the nayib/add-schema-ref branch September 18, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants