Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add back return value from is_seurat_convertible #1147

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

joyceyan
Copy link
Contributor

@joyceyan joyceyan commented Dec 5, 2024

Reason for Change

makes the change to remove is_seurat_convertible more backwards compatible friendly by continuing to return False. we can remove this return value entirely with a future release, though i think it should technically be part of a major update if we do

Changes

  • returns False as the final tuple value always

Testing

updated unit tests

Notes for Reviewer

@joyceyan joyceyan requested a review from ejmolinelli December 5, 2024 19:38
Copy link
Contributor

@ejmolinelli ejmolinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I don't see anything missing.

@joyceyan joyceyan merged commit 3d2fa6d into main Dec 5, 2024
7 of 8 checks passed
@joyceyan joyceyan deleted the joyce/add-back-return branch December 5, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants