Skip to content

Commit

Permalink
fix: Make install run within Makefile string interpolation issue (ope…
Browse files Browse the repository at this point in the history
…n-telemetry#2520)

* fix: Make install run within Makefile to work
this fix fixes errors such as "github.com/open-telemetry/opentelemetry-operator/internal/version.version=0.91.0-20-gd013d45": invalid char '='

Signed-off-by: Todd  Yan <[email protected]>

* fix makefile for run

---------

Signed-off-by: Todd  Yan <[email protected]>
  • Loading branch information
Toaddyan authored Jan 26, 2024
1 parent f2171d1 commit 6ea5f7f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Current Operator version
VERSION ?= $(shell git describe --tags | sed 's/^v//')
VERSION_DATE ?= $(shell date -u +'%Y-%m-%dT%H:%M:%SZ')
VERSION_PKG ?= "github.com/open-telemetry/opentelemetry-operator/internal/version"
VERSION_PKG ?= github.com/open-telemetry/opentelemetry-operator/internal/version
OTELCOL_VERSION ?= "$(shell grep -v '\#' versions.txt | grep opentelemetry-collector | awk -F= '{print $$2}')"
OPERATOR_VERSION ?= "$(shell grep -v '\#' versions.txt | grep operator= | awk -F= '{print $$2}')"
TARGETALLOCATOR_VERSION ?= $(shell grep -v '\#' versions.txt | grep targetallocator | awk -F= '{print $$2}')
Expand Down Expand Up @@ -119,7 +119,7 @@ operator-opamp-bridge:
# Run against the configured Kubernetes cluster in ~/.kube/config
.PHONY: run
run: generate fmt vet manifests
ENABLE_WEBHOOKS=$(ENABLE_WEBHOOKS) go run -ldflags ${OPERATOR_LDFLAGS} ./main.go --zap-devel
ENABLE_WEBHOOKS=$(ENABLE_WEBHOOKS) go run -ldflags "${OPERATOR_LDFLAGS}" ./main.go --zap-devel

# Install CRDs into a cluster
.PHONY: install
Expand Down

0 comments on commit 6ea5f7f

Please sign in to comment.