Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test transition info #321

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Test transition info #321

wants to merge 6 commits into from

Conversation

gprashant17
Copy link

Added unit tests for TransitionInfo class inside runners.utils. A few things to note

  1. The get_info method takes terminated and truncated as inputs along with agent. However, when I call the method in the unit test, it says that there are only two arguments - agent and done
  2. In the get_stacked_state method, I am getting an error in this line:
    stacked_observation = concatenate(
    . I think there's an issue with concatenating.
  3. Yet to write comments

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gprashant17 gprashant17 requested review from TongTongX and removed request for Prishruit January 26, 2023 23:21
@dapatil211 dapatil211 changed the base branch from main to dev January 27, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant