Env tutorial #305
Env tutorial #305
Conversation
mrsamsami
added
documentation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
notebooks/env.ipynb
Outdated
| @@ -0,0 +1,628 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #5. !pip install RLHive['gym_minigrid']
This should be a separate PR, but it should probably be merged before this one. gym_minigrid is now just minigrid, and it's available as part of the Farama Foundation org. If you could update this tutorial to reflect those changes, that would be great.
Reply via ReviewNB
There was a problem hiding this comment.
So should I wait until the new PR is merged? Or I should install by directly installing Minigrid by running pip install minigrid?
notebooks/env.ipynb
Outdated
| @@ -0,0 +1,628 @@ | |||
| { | |||
There was a problem hiding this comment.
You need to give an example of how to use this (eg configs). Also what to do when they have a custom environment that is a gym environment (eg registering with gym and then using hive).
Reply via ReviewNB
There was a problem hiding this comment.
I'm not sure if I understand your point here. What exactly do you mean by "example of how to use this"? We'll use the environment we've created in the following subsections. If you're only talking about custom environments and registering them, don't you think moving them up would make the tutorial a bit confusing?
notebooks/env.ipynb
Outdated
| @@ -0,0 +1,628 @@ | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Two comments/questions:
- Are you making the gym_minigrid -> minigrid changes?
- Can you move the gym registering stuff up higher to the explanation of where you first talk about the GymEnv? both pieces seem a bit out of place when not connected to each other.
Other than that, i think its good.
"Environments" tutorial added to notebooks directory.