User: Fix usergroup table loading and form updates - refs BT#22277 #5984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -1588,16 +1588,32 @@ public function save($params, $showQuery = false) | |||
| return false; | |||
| } | |||
|
|
|||
| public function update($params, $showQuery = false) | |||
| public function update($params, $showQuery = false): bool | |||
| @@ -1200,11 +1200,13 @@ public static function grid_js( | |||
|
|
|||
| // Default row quantity | |||
| if (!isset($extra_params['rowList'])) { | |||
| $extra_params['rowList'] = [20, 50, 100, 500, 1000, $all_value]; | |||
| $defaultRowList = [20, 50, 100, 500, 1000, $all_value]; | |||
There was a problem hiding this comment.
Variable "all_value" is not in valid camel caps format
| @@ -1588,16 +1588,32 @@ | |||
| return false; | |||
| } | |||
|
|
|||
| public function update($params, $showQuery = false) | |||
| public function update($params, $showQuery = false): bool | |||
There was a problem hiding this comment.
The method update() has an NPath complexity of 768. The configured NPath complexity threshold is 200.
| @@ -1588,16 +1588,32 @@ | |||
| return false; | |||
| } | |||
|
|
|||
| public function update($params, $showQuery = false) | |||
| public function update($params, $showQuery = false): bool | |||
There was a problem hiding this comment.
Avoid unused parameters such as '$showQuery'.
| $rowList = $rowList['options']; | ||
| $rowList[] = $all_value; | ||
| } else { |
There was a problem hiding this comment.
The method grid_js uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
|
Code Climate has analyzed commit 481e899 and detected 11 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.