Internal: Fix score calculation across reports and interfaces - refs …

…BT#22096
chamilo · Dec 3, 2024 · 248d6fd · 248d6fd
1 parent 9b1f1e6
commit 248d6fd
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 13 deletions.
diff --git a/public/main/inc/lib/TrackingCourseLog.php b/public/main/inc/lib/TrackingCourseLog.php
@@ -664,11 +664,7 @@ public static function getUserData(
         $totalSurveys = 0;
         $totalExercises = ExerciseLib::get_all_exercises(
             $courseInfo,
-            $sessionId,
-            false,
-            null,
-            false,
-            3
+            $sessionId
         );
 
         if (empty($sessionId)) {

diff --git a/public/main/inc/lib/exercise.lib.php b/public/main/inc/lib/exercise.lib.php
@@ -3000,7 +3000,9 @@ public static function get_all_exercises(
 
         $repo = Container::getQuizRepository();
 
-        return $repo->findAllByCourse($course, $session, (string) $search, $active);
+        return $repo->findAllByCourse($course, $session, (string) $search, $active)
+            ->getQuery()
+            ->getResult();
     }
 
     /**

diff --git a/public/main/inc/lib/tracking.lib.php b/public/main/inc/lib/tracking.lib.php
@@ -2640,19 +2640,15 @@ public static function get_exercise_student_average_best_attempt(
         $sessionId
     ) {
         $result = 0;
-
-        if ($exercise_list instanceof \Doctrine\ORM\QueryBuilder) {
-            $exercise_list = $exercise_list->getQuery()->getResult();
-        }
-
         if (!empty($exercise_list) && (is_array($exercise_list) || $exercise_list instanceof \Countable)) {
             foreach ($exercise_list as $exercise_data) {
                 $exercise_id = $exercise_data->getIid();
                 $best_attempt = Event::get_best_attempt_exercise_results_per_user(
                     $user_id,
                     $exercise_id,
                     $courseId,
-                    $sessionId
+                    $sessionId,
+                    false
                 );
 
                 if (!empty($best_attempt) && !empty($best_attempt['max_score'])) {
@@ -2940,6 +2936,7 @@ public static function get_avg_student_score(
                 WHERE
                     lp_id IN (".implode(',', $lp_list).")
                     $condition_user1
+                    $sessionCondition
                 GROUP BY lp_id, user_id";
         //AND        session_id = $sessionId
 

diff --git a/src/CourseBundle/Repository/CQuizRepository.php b/src/CourseBundle/Repository/CQuizRepository.php
@@ -40,7 +40,9 @@ public function findAllByCourse(
         $this->addCategoryQueryBuilder($categoryId, $qb);
         $this->addActiveQueryBuilder($active, $qb);
         $this->addNotDeletedQueryBuilder($qb);
-        $this->addTitleQueryBuilder($title, $qb);
+        if (!empty($title)) {
+            $this->addTitleQueryBuilder($title, $qb);
+        }
 
         return $qb;
     }