Update giphy.js #129
Open
Update giphy.js #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed you api key from giphy command
|
https://giphy.api-docs.io/1.0/sticker/search It's a public API key. |
MrARM
reviewed
Aug 13, 2018
| @@ -5,7 +5,7 @@ exports.commands = [ | |||
| var qs = require("querystring"); | |||
|
|
|||
| var giphy_config = { | |||
| "api_key": "dc6zaTOxFJmzC", | |||
| "api_key": "your key here", | |||
There was a problem hiding this comment.
Yeah, I agree with @ScriptKi77y there isn't a good reason to remove it.
|
Linking this with #128. I'm inclined to keep it as is for now since the key is public and no there's no automated way to request one, but good to have this in case we do need to remove it. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed you api key from giphy command