Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix check_response #39

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix check_response #39

merged 1 commit into from
Dec 7, 2023

Conversation

erwin-wee
Copy link
Collaborator

Description

  • fix check_response, json rpc errors are now displayed more cleanly without stack traces
  • added rpc_error_code_exclusions property to exclude certain error codes from failing the response
  • re-enabled random request id in generate_request method to enable matching of request -> response

Issues Resolved

  • json rpc errors were displayed with stack traces in Locust report, which was unnecessary

@erwin-wee
fix check_response
dccb66f 
- fix check_response, json rpc errors are now displayed more cleanly without stack traces
- added rpc_error_code_exclusions property to exclude certain error codes from failing the response
- re-enabled random request id in generate_request method to enable matching of request -> response
@erwin-wee erwin-wee added the bug Something isn't working label Dec 6, 2023
@erwin-wee erwin-wee self-assigned this Dec 6, 2023
@erwin-wee erwin-wee merged commit e405cfe into main Dec 7, 2023
5 checks passed
@erwin-wee erwin-wee deleted the fix/check-responses branch December 12, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-at-chainstack denis-at-chainstack denis-at-chainstack approved these changes

Assignees

@erwin-wee erwin-wee

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erwin-wee @denis-at-chainstack