Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to services #56

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Add tags to services #56

merged 4 commits into from
Dec 3, 2024

Conversation

havan
Copy link
Member

@havan havan commented Nov 30, 2024

This PR adds service tags according to the service tags spec to all of the defined services.

@havan havan requested a review from SamJaarsma as a code owner November 30, 2024 13:57
@havan havan requested a review from Noctunus November 30, 2024 13:58
proto/cmp/services/book/v1/validate.proto Outdated Show resolved Hide resolved
proto/cmp/services/book/v2/validate.proto Outdated Show resolved Hide resolved
proto/cmp/services/book/v3/validate.proto Outdated Show resolved Hide resolved
proto/cmp/services/partner/v1/partner_configuration.proto Outdated Show resolved Hide resolved
proto/cmp/services/partner/v2/partner_configuration.proto Outdated Show resolved Hide resolved
@havan havan force-pushed the ekrem/add-service-tags-r2 branch from 08d34d0 to 242a61e Compare December 2, 2024 23:06
Copy link
Contributor

@SamJaarsma SamJaarsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@havan havan merged commit 612e193 into dev Dec 3, 2024
9 checks passed
@havan havan deleted the ekrem/add-service-tags-r2 branch December 3, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants