Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements #1631

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Various improvements #1631

wants to merge 5 commits into from

Conversation

frankrousseau
Copy link
Contributor

@frankrousseau frankrousseau commented Dec 20, 2024 •
edited
Loading

Problem

  • Scrolling wide entity lists via scrollbars is a little bit painful
  • Pictures are always reloaded in playlists
  • Some locales appear on several lines in the sidebar

Solution

  • Solution test: Allow to grab the shot list to scroll it
  • In playlists prepare all pictures and switch between them
  • Change font size in the sidebar for Japanese and French locales

@NicoPennec
Copy link
Member

Another approach to the sidebar is to set its width to be dynamic, as below:

aside {
  /* width: 230px; */
  min-width: 230px;
  max-width: 350px;
}

aside.hidden-bar {
  left: -350px;
}

NicoPennec
NicoPennec reviewed Dec 20, 2024
View reviewed changes
src/components/lists/ShotList.vue
}
},

mounted() {
this.stickedColumns =
JSON.parse(localStorage.getItem(this.localStorageStickKey)) || {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use the getObjectPreference helper from preference.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoPennec NicoPennec NicoPennec left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@frankrousseau frankrousseau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankrousseau @NicoPennec