Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add component RandomStoryList and new common data #372

Closed
wants to merge 8 commits into from

Conversation

daria31v
Copy link
Collaborator

No description provided.

@daria31v daria31v requested review from met and nataliadiak October 22, 2023 22:54
@met
Copy link
Collaborator

met commented Oct 23, 2023

@daria31v On big screen this looks good. But not on small screens. Try in Chrome to simulate mobile devices and you will see it https://developer.chrome.com/docs/devtools/device-mode/ Probably needs just a little of CSS polishing.

Copy link
Collaborator

@met met left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I see two problems here:

  • in Slovak web version it suggest fairytales that are not available in Slovak language
  • there is problem with picture responsibility. On some screen with it looks good, on some not. Here screenshot. Try to change browser window width and you will see it too.

image

@met
Copy link
Collaborator

met commented Nov 23, 2023

Closing this due to conflicts. Continuing in a new PR #376

@met met closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants