Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add legal pages and copyright notice #543

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

RicoPleasure
Copy link
Contributor

Description

Created pages for Terms of Service, Privacy Policy and Cookie Policy. Added links to them below the schedule when on large screens and at the bottom of the sidebar menu when on mobile.

Pages

image

image

image

image

Links

image

image

@RicoPleasure RicoPleasure changed the title Ep/legal pages feat: add legal pages and copyright notice Nov 19, 2024
@RicoPleasure RicoPleasure self-assigned this Nov 19, 2024
@RicoPleasure RicoPleasure linked an issue Nov 19, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@FilipeR13 FilipeR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🤩

lib/atomic_web/components/sidebar.ex Outdated Show resolved Hide resolved
lib/atomic_web/components/sidebar.ex Outdated Show resolved Hide resolved
lib/atomic_web/live/home_live/index.html.heex Outdated Show resolved Hide resolved
</div>
<!-- Link to Home (hidden on mobile) -->
<div class="flex place-items-center lg:pr-12">
<.link class="atomic-button atomic-button--white atomic-button--md hidden sm:block" navigate={~p"/"}>Back home</.link>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this link to the button component. Make use of the attribute patch so you mantain the funcitionality of the link.
Put the text Back Home in a gettext("Back Home")

<!-- Link to Home (hidden on mobile) -->
<div class="flex place-items-center lg:pr-12">
<.link class="atomic-button atomic-button--white atomic-button--md hidden sm:block" navigate={~p"/"}>Back home</.link>
<.link class="atomic-button atomic-button--md hero-home block text-zinc-400 sm:hidden" navigate={~p"/"}></.link>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if the component button allows only a icon without text, if so, change this too.

~H"""
<section class="flex justify-center bg-zinc-800 p-10 font-semibold text-white">
<p class="flex w-full justify-center md:w-2/3">
Lorem ipsum dolor sit amet.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Lorem ipsum dolor sit amet.
<%= getttext("Lorem ipsum dolor sit amet.") %>

Comment on lines +11 to +18
<p class="text-xs font-semibold text-zinc-400 hover:underline">Terms of Service</p>
</.link>
<.link navigate={~p"/privacy"} class="shrink-0 select-none">
<p class="text-xs font-semibold text-zinc-400 hover:underline">Privacy Policy</p>
</.link>
<.link navigate={~p"/cookies"} class="shrink-0 select-none">
<p class="text-xs font-semibold text-zinc-400 hover:underline">Cookie Policy</p>
</.link>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add gettexts to the text on the links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legal pages and copyright notice
2 participants