-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webhook troubleshooting documentation to including necessary curl command. #1611
base: master
Are you sure you want to change the base?
Conversation
…url argument Signed-off-by: Justin Ray <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
--service-name cert-manager-webhook-ca \ | ||
--cacert <(kubectl -n cert-manager get secret cert-manager-webhook-ca -ojsonpath='{.data.ca\.crt}' | base64 -d) \ | ||
https://cert-manager-webhook.cert-manager.svc:10250/validate 2>&1 -d@- <<'EOF' | sed '/^* /d; /bytes data]$/d; s/> //; s/< //' | ||
{"kind":"AdmissionReview","apiVersion":"admission.k8s.io/v1","request":{"requestKind":{"group":"cert-manager.io","version":"v1","kind":"Certificate"},"requestResource":{"group":"cert-manager.io","version":"v1","resource":"certificates"},"name":"foo","namespace":"default","operation":"CREATE","object":{"apiVersion":"cert-manager.io/v1","kind":"Certificate","spec":{"dnsNames":["foo"],"issuerRef":{"group":"cert-manager.io","kind":"Issuer","name":"letsencrypt"},"secretName":"foo","usages":["digital signature"]}}}} | ||
EOF | ||
``` | ||
|
||
> ℹ️ if the `-H "Content-Type: application/json"` is omitted from the command above, you are likely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can you start the sentence with a capital letter
> ℹ️ if the `-H "Content-Type: application/json"` is omitted from the command above, you are likely | |
> ℹ️ If the `-H "Content-Type: application/json"` is omitted from the command above, you are likely |
The documentation has been update to reflect a needed change in the curl incantation for the webhook troubleshooting.
Using the original listed curl command to check the webhook (after setting up the forward):
I get back
Then I add
-H "Content-Type: application/json"
:And I get back the expected response: