-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More details about the Route53 changes #1567
More details about the Route53 changes #1567
Conversation
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
2fdaffd
to
9bdaa19
Compare
9bdaa19
to
6a47c5b
Compare
Signed-off-by: Richard Wall <[email protected]>
6a47c5b
to
03cb1ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted a typo - the rest looks great 😁
Co-authored-by: Ashley Davis <[email protected]> Signed-off-by: Richard Wall <[email protected]>
Co-authored-by: Ashley Davis <[email protected]> Signed-off-by: Richard Wall <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Looks great, cheers!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
295025e
into
cert-manager:release-next
Preview: https://deploy-preview-1567--cert-manager.netlify.app/docs/releases/release-notes/release-notes-1.16#route53-dns01-solver-cleanup