Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More details about the Route53 changes #1567

Merged

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Sep 27, 2024

@cert-manager-prow cert-manager-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2024
Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 65b12a2
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/66f6dc4e2803bc0008db230c
😎 Deploy Preview https://deploy-preview-1567--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wallrj wallrj force-pushed the more-route53-release-notes branch from 2fdaffd to 9bdaa19 Compare September 27, 2024 15:58
@wallrj wallrj changed the title WIP: More details about the Route53 changes More details about the Route53 changes Sep 27, 2024
@cert-manager-prow cert-manager-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2024
@wallrj wallrj force-pushed the more-route53-release-notes branch from 9bdaa19 to 6a47c5b Compare September 27, 2024 16:10
@wallrj wallrj force-pushed the more-route53-release-notes branch from 6a47c5b to 03cb1ab Compare September 27, 2024 16:13
@wallrj wallrj requested a review from SgtCoDFish September 27, 2024 16:13
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a typo - the rest looks great 😁

content/docs/releases/release-notes/release-notes-1.16.md Outdated Show resolved Hide resolved
content/docs/releases/release-notes/release-notes-1.16.md Outdated Show resolved Hide resolved
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Looks great, cheers!

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2024
@cert-manager-prow cert-manager-prow bot merged commit 295025e into cert-manager:release-next Sep 27, 2024
7 checks passed
@wallrj wallrj deleted the more-route53-release-notes branch September 27, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants