Cview-issuer for cert-manager

[djkormo]

New issuer has been created for cert-manager. It uses cview as dedicated CA. The website of this produkt product https://www.secure-ly.com/c-view-professional-certificates-lifecycle-management/ . Issuer is not open-sourced.

[netlify]

✅ Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	1b44994
🔍 Latest deploy log	https://app.netlify.com/sites/cert-manager/deploys/66f1cfd31feebf0008640134
😎 Deploy Preview	https://deploy-preview-1541--cert-manager.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Dror1966]

Hi, Can you prioritize this issue?

[djkormo]

@jakexks Please help me with this npm check. I do not understand why it is failed.

[spelling]     content/docs/configuration/issuers.md
[spelling]        18 | | 🥈   | cview-issuer                | [📄][config: 
[spelling]        18 | ig:cview-issuer]           | [Cview issuer][ca:cview-issuer]  

[djkormo]

The spelling has been corrected.

[cert-manager-prow]

@djkormo: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[cert-manager-prow]

@djkormo: GitHub didn't allow me to assign the following users: sorah.

Note that only cert-manager members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @sorah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[SgtCoDFish]

Hey, thanks for contributing!

It looks like the deploy preview is showing a broken link for this. Looks like the ca:cview-issuer link hasn't been added.

Could you fix that? I'd be happy to merge then!

[inteon]

Do you have a releases page? We have to make sure the issuer has had a release in the last 12 months.

Also, can you confirm the following (does not require a proof):

• These issuers are known to support and honor approval.

[djkormo]

There is a release page for helm chart. But the release of issuer image is in a private repo.
Images for issuer are visible on docker hub . https://hub.docker.com/r/devsecurely/cview-issuer/tags

[SgtCoDFish]

Thanks for updating the link, it looks correct now!

There's one last thing based on inteon's comment - can you confirm that your issuer honors approval?

That is, it will not issue for a cert request which is not marked "Approved"?

If your issuer is based on issuer-lib then it should handle approval. If it's more custom it might not, so we need to check!

[inteon]

/approve
/lgtm
/hold We can unhold once you confirm it does handle approval.

[cert-manager-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djkormo, inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [inteon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[djkormo]

Code was written on the base from this repo
https://github.com/cert-manager/sample-external-issuer/tree/main

It does handle approval.

[inteon]

/unhold

see #1541 (comment)