Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update twitter icon to x [Fixes #1321] #1323

Conversation

sarthak-kumar-shailendra
Copy link
Contributor

@sarthak-kumar-shailendra sarthak-kumar-shailendra commented Oct 7, 2023

Fixing the issue [fixes https://github.com//issues/1321]

hacktober

Changed the svg of twitter icon to x
Screenshot 2023-10-07 at 4 48 39 PM
Screenshot 2023-10-07 at 4 48 45 PM

Signed-off-by: sarthak-kumar-shailendra <[email protected]>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2023
@netlify
Copy link

netlify bot commented Oct 7, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 4d6f885
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/6521442de5e5c90009bd3b27
😎 Deploy Preview https://deploy-preview-1323--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
@jetstack-bot jetstack-bot merged commit b3af302 into cert-manager:master Oct 9, 2023
1 check passed
@sarthak-kumar-shailendra
Copy link
Contributor Author

@inteon can you add hacktoberfest-accepted label to this PR

@inteon
Copy link
Member

inteon commented Oct 9, 2023

@sarthak-kumar-shailendra I added the label, although I don't think it is strictly required for hacktoberfest.

@sarthak-kumar-shailendra
Copy link
Contributor Author

Thanks a lot! Actually, it was showing not accepted in hacktoberfest for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. hacktoberfest-accepted lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants