Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update csi-driver project page #1301

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Conversation

SgtCoDFish
Copy link
Member

This page has a lot of prose which I think benefits from clarification. There are also many typos and the first section of our installation instructions talks about an ancient Kubernetes version, with instructions which will apply to approximately nobody.

This PR should hopefully make the docs simpler and easier to follow.

This page has a lot of prose which I think benefits from clarification.
There are also many typos and the first section of our installation
instructions talks about an ancient Kubernetes version, with
instructions which will apply to approximately nobody.

This PR should hopefully make the docs simpler and easier to follow.

Signed-off-by: Ashley Davis <[email protected]>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 20, 2023
@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 421f5f5
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/650b2593ad858c0008521443
😎 Deploy Preview https://deploy-preview-1301--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Ashley Davis <[email protected]>
Signed-off-by: Ashley Davis <[email protected]>
@SgtCoDFish SgtCoDFish requested a review from inteon September 20, 2023 17:06
Copy link
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SgtCoDFish, this makes the page a lot easier to read!

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@inteon
Copy link
Member

inteon commented Sep 20, 2023

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2023
@jetstack-bot jetstack-bot merged commit 4f73bfe into cert-manager:master Sep 20, 2023
1 check passed
@SgtCoDFish SgtCoDFish deleted the csidriver branch September 21, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants