Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise the usage section & move missing topics to this section #1291

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

inteon
Copy link
Member

@inteon inteon commented Sep 7, 2023

  • renames the menu items
  • moves the CertificateRequest item from the concepts section to the usages section

TODO (in future PR):
merge the Certificate item from the concepts section with the Certificate item in the usages section

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 7, 2023
@inteon inteon force-pushed the move_project_items branch from 2e92a51 to 0050cb7 Compare September 7, 2023 13:29
@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 2e92a51
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/64f9d0142caf620008b2c42d
😎 Deploy Preview https://deploy-preview-1291--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit ec94f3d
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/6527a212ac8fc800092737b7
😎 Deploy Preview https://deploy-preview-1291--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@inteon inteon force-pushed the move_project_items branch from 0050cb7 to 26eb50d Compare September 8, 2023 06:52
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2023
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2023
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2023
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2023
@inteon inteon force-pushed the move_project_items branch 4 times, most recently from 68d5b71 to 80b7457 Compare October 6, 2023 14:12
@inteon inteon force-pushed the move_project_items branch from 80b7457 to ec94f3d Compare October 12, 2023 07:36
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much neater and consistent.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023
@jetstack-bot jetstack-bot merged commit 6f721df into cert-manager:master Oct 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants