build: update Go 1.23

[iPraveenParihar]

Describe what this PR does

-build: update Go 1.23

Fixes: #5015

Checklist:

• Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
• Reviewed the developer guide on Submitting a Pull Request
• Pending release notes updated with breaking and/or notable changes for the next major release.
• Documentation has been updated, if necessary.
• Unit tests have been added, if necessary.
• Integration tests have been added, if necessary.

---

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

• /retest ci/centos/<job-name>: retest the <job-name> after unrelated
  failure (please report the failure too!)

[iPraveenParihar]

golangci-lint gettting killed unexpectedly

level=info msg="[linters_context] importas settings found, but no aliases listed. List aliases under alias: key."
./scripts/lint-go.sh: line 9:    17 Killed                  golangci-lint --config=scripts/golangci.yml run ./... -v
make: *** [Makefile:124: go-lint] Error 137

trying with latest version of golangci-lint

[iPraveenParihar]

updating golangci-lint to latest produces many lint issues - log

updating golangci-lint to minimum version supported by Go v1.23

[black-dragon74]

updating golangci-lint to latest produces many lint issues - log

Magic number used be ignored earlier.

Static check for arg order is likely something added in the new releases of golangci-lint? If so we can exclude them in scripts/golangci.yml.in or maybe fix those specific issues?

[iPraveenParihar]

Okay, I'll ignore the magic number for now. Also, there are other lint failures - gosec, staticcheck, govet
I'll fix them

Thanks for taking a look.

[iPraveenParihar]

Magic number used be ignored earlier.

Actually the gomnd is replaced with mnd

[nixpanic]

Fixes like you have in rbd: fix arguments have the wrong order (staticcheck) can also be sent as separate PR to make reviewing of this one easier. You can leave the error/warning from golangci-lint in the PR description.

[iPraveenParihar]

Fixes like you have in rbd: fix arguments have the wrong order (staticcheck) can also be sent as separate PR to make reviewing of this one easier. You can leave the error/warning from golangci-lint in the PR description.

Sounds good to me, I'll open up a new PR to fix the golangci-lint errors.
Thanks!

[iPraveenParihar]

Hey @nixpanic, I tried to include the golangci-lint changes in this PR.
Now I see gosec lint errors - G115: integer overflow conversion , can we disable this rule for now and address later? Also, there seems to be an false positive reporting - securego/gosec#1212

[nixpanic]

@iPraveenParihar , disabling only gosec rule G115 should be possible too? If you do that, make sure to open an issue for it so we can track it down later once gosec reports fewer false negatives.

[iPraveenParihar]

@iPraveenParihar , disabling only gosec rule G115 should be possible too? If you do that, make sure to open an issue for it so we can track it down later once gosec reports fewer false negatives.

Created a issue for it - #5040

[nixpanic]

This is rather ugly, not only because of the added _, also because comparing versions as a string.

Maybe it makes more sense to convert v.Major and v.Minor to integers?

[nixpanic]

a bit more context in the errors would help here.

framework.Failf("ensureStatSucceeds failed for pod %q: %v", deplPods[i].Name, err.Error())

Something like that really helps the person receiving the error a lot. These things can/should be done everywhere.