Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update VolumeGroupSnapshot to v1beta1 #5021

Merged
merged 7 commits into from
Dec 17, 2024
Merged

update VolumeGroupSnapshot to v1beta1 #5021

merged 7 commits into from
Dec 17, 2024

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Dec 12, 2024 •
edited by nixpanic
Loading

Updating the required files to move VGS from alpha to beta API.

@Madhu-1 Madhu-1 mentioned this pull request Dec 12, 2024
Closed
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Dec 12, 2024

/test ci/centos/mini-e2e/k8s-1.31

@Madhu-1 Madhu-1 requested review from a team December 12, 2024 13:14
nixpanic
nixpanic reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, all other things look good to me.

scripts/install-snapshot.sh Show resolved Hide resolved
@nixpanic nixpanic changed the title update VGS to v1beta1 update VolumeGroupSnapshot to v1beta1 Dec 12, 2024
@Madhu-1 Madhu-1 requested review from nixpanic and a team December 12, 2024 18:47
nixpanic
nixpanic previously approved these changes Dec 12, 2024
View reviewed changes
@nixpanic nixpanic requested a review from a team December 12, 2024 20:21
@nixpanic
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Dec 13, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Dec 13, 2024
@Madhu-1 Madhu-1 added the backport-to-release-v3.13 Label to backport from devel to release-v3.13 branch label Dec 16, 2024
@nixpanic
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 17, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at a88f86e

@Madhu-1
build: update snapshot version
51b28bc 
updating the snapshot version in
the build.env

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1
deploy: update template for vgs flag
6a4bf66 
updating the snapshotter image to 8.2.0
and update the flag to enable vgs
feature.

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1
helm: update template for vgs flag
9c460e8 
updating the snapshotter image to 8.2.0
and update the flag to enable vgs
feature.

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1
e2e: update snapshot to v1beta1
08047d0 
updating the snapshot client and
test to use v1beta1 client and API.

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1
ci: adjust the snapshot to enable vgs
7542ac2 
updating the snapshot container ARG
to enable the vgs feature.

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1
deploy: update the vgs api to v1beta1
63b2abb 
updating the yamls of vgs to v1beta1

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1
e2e: remove vsg flag present in older snapshotter
d38a3e9 
Remove the vsg flag present in the older snapshotter
which is meant only for the Alpha Release and we are
no longer installing Alpha CRD.

Signed-off-by: Madhu Rajanna <[email protected]>
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Dec 17, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Dec 17, 2024
@mergify mergify bot merged commit a88f86e into ceph:devel Dec 17, 2024
37 checks passed
@mergify mergify bot mentioned this pull request Dec 17, 2024
Merged
@Rakshith-R Rakshith-R mentioned this pull request Dec 20, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@yati1998 yati1998 yati1998 approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
backport-to-release-v3.13 Label to backport from devel to release-v3.13 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Madhu-1 @nixpanic @ceph-csi-bot @iPraveenParihar @yati1998