Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Add Modify volume rpc support #4916

Draft
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

Nikhil-Ladha
Copy link
Contributor

Add ControllerModifyVolume RPC support for ceph-csi.

Describe what this PR does

Provide some context for the reviewer

Is there anything that requires special attention

Do you have any questions?

Is the change backward compatible?

Are there concerns around backward compatibility?

Provide any external context for the change, if any.

For example:

  • Kubernetes links that explain why the change is required
  • CSI spec related changes/catch-up that necessitates this patch
  • golang related practices that necessitates this change

Related issues

Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.

Fixes: #issue_number

Future concerns

List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide
    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes

    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@Nikhil-Ladha Nikhil-Ladha marked this pull request as draft October 24, 2024 07:41
@Nikhil-Ladha
Copy link
Contributor Author

Nikhil-Ladha commented Oct 24, 2024

Just a POC PR for cephfs component, if the approach looks right then will make the changes for rbd and nfs as well.
cc @Madhu-1 @nixpanic

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Oct 24, 2024

@Nikhil-Ladha it would be good to update what you are trying to achieve in the PR description and commit and what are the parameters we are planning to have modified.

Please update or open an issue to cover

  • Documentation (how to use this feature)
  • Required Yaml changes
  • E2E changes to ensure the feature works
  • what are immutable parameters in the drivers.

@nixpanic nixpanic changed the title [Draft] Add Modfify volume rpc support [Draft] Add Modify volume rpc support Nov 8, 2024
Copy link

github-actions bot commented Dec 8, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 8, 2024
add ControllerModifyVolume RPC support for cephfs

Signed-off-by: Nikhil-Ladha <[email protected]>
@Nikhil-Ladha Nikhil-Ladha force-pushed the issue4662/modify-vol-csi branch from 73c8d15 to 2dff79f Compare December 9, 2024 09:45
@github-actions github-actions bot removed the stale label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants