Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd: rename setImageOptions() to constructImageOptions() #4833

Merged
merged 1 commit into from
Sep 12, 2024
Merged

rbd: rename setImageOptions() to constructImageOptions() #4833

merged 1 commit into from
Sep 12, 2024
+19 −15

Conversation

nixpanic
Copy link
Member

@nixpanic nixpanic commented Sep 11, 2024 •
edited
Loading

A function called setImageOptions() is expected to set the passed
options on the volume. However, the passed options parameter is only
filled with the options that should get set on the RBD-image at the time
of creation.

The naming of the function, and it's parameter is confusing. Rename the
function to constructImageOptions() and return the ImageOptions to
make it easier to understand.

Depends-on: #4835

@mergify mergify bot added the component/rbd Issues related to RBD label Sep 11, 2024
@nixpanic nixpanic force-pushed the cleanup/rbd/setImageOptions branch from 9667584 to 233d1f1 Compare September 11, 2024 16:25
@nixpanic nixpanic requested a review from a team September 11, 2024 16:26
iPraveenParihar
iPraveenParihar approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@iPraveenParihar iPraveenParihar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Sep 12, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 12, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic
rbd: rename setImageOptions() to constructImageOptions()
a751b65 
A function called `setImageOptions()` is expected to set the passed
options on the volume. However, the passed options parameter is only
filled with the options that should get set on the RBD-image at the time
of creation.

The naming of the function, and it's parameter is confusing. Rename the
function to `constructImageOptions()` and return the ImageOptions to
make it easier to understand.

Signed-off-by: Niels de Vos <[email protected]>
@nixpanic nixpanic force-pushed the cleanup/rbd/setImageOptions branch from 233d1f1 to a751b65 Compare September 12, 2024 06:09
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Sep 12, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Sep 12, 2024
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Sep 12, 2024

/retest ci/centos/k8s-e2e-external-storage/1.30

@nixpanic
Copy link
Member Author

/retest ci/centos/k8s-e2e-external-storage/1.29

@nixpanic
Copy link
Member Author

/retest ci/centos/k8s-e2e-external-storage/1.30

@nixpanic
Copy link
Member Author

/retest ci/centos/k8s-e2e-external-storage/1.31

@nixpanic
Copy link
Member Author

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 12, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Sep 12, 2024

depends on #4835

@nixpanic
Copy link
Member Author

/retest ci/centos/k8s-e2e-external-storage

@nixpanic nixpanic mentioned this pull request Sep 12, 2024
Merged
@mergify mergify bot merged commit 42fc0b6 into ceph:devel Sep 12, 2024
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

Assignees
No one assigned
Labels
cleanup component/rbd Issues related to RBD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nixpanic @Madhu-1 @ceph-csi-bot @iPraveenParihar