cephfs: Add CSI-Addons NetworkFence support to CephFS #4113

riya-singhal31 · 2023-09-11T09:32:34Z

adds client eviction to cephfs, based
on the IPs in cidr block, it evicts those IPs from
the network.

updates: #3969

nixpanic

An early review. Please add unit-tests for functions like fetchIP() so that the parsing of the client IP-address is validated.

nixpanic · 2023-09-11T15:35:55Z

internal/csi-addons/networkfence/fencing.go

@@ -38,6 +39,27 @@ type NetworkFence struct {
 	cr       *util.Credentials
 }

+// ActiveClient represents the structure of an active client.
+type ActiveClient struct {


this struct is not used outside of this package, you do not need to export it, so call it activeClient.

And also remove unwanted members from the struct

nixpanic · 2023-09-11T15:38:39Z

internal/csi-addons/networkfence/fencing.go

+	return ipCidr.Contains(ipAddress)
+}
+
+func fetchIP(clientInfo string) (string, error) {


make this

func (ac *activeClient) fetchIP() (string, error) { clientInfo := ac.Inst ...

and then call

clientIP, err := client.fetchIP()

further below.

nixpanic · 2023-09-11T15:40:01Z

internal/csi-addons/networkfence/fencing.go

@@ -132,6 +154,90 @@ func (nf *NetworkFence) AddNetworkFence(ctx context.Context) error {
 	return nil
 }

+func listActiveClients(ctx context.Context, mdsDaemonID string) ([]ActiveClient, error) {
+	cmd := []string{"tell", fmt.Sprintf("mds.%s", mdsDaemonID), "client", "ls"}
+	stdout, stdErr, err := util.ExecCommand(ctx, "ceph", cmd...)


make sure to leave a FIXME: comment to use go-ceph in the future

Yes this is much required

internal/csi-addons/cephfs/network_fence.go

Madhu-1 · 2023-09-12T06:51:32Z

internal/csi-addons/cephfs/network_fence.go

+	"google.golang.org/grpc/status"
+)
+
+// FenceControllerServer struct of cephfs CSI driver with supported methods


cephfs to cephFS

internal/csi-addons/cephfs/network_fence.go

Madhu-1 · 2023-09-12T06:54:06Z

internal/csi-addons/networkfence/fencing.go

@@ -132,6 +154,90 @@ func (nf *NetworkFence) AddNetworkFence(ctx context.Context) error {
 	return nil
 }

+func listActiveClients(ctx context.Context, mdsDaemonID string) ([]ActiveClient, error) {
+	cmd := []string{"tell", fmt.Sprintf("mds.%s", mdsDaemonID), "client", "ls"}
+	stdout, stdErr, err := util.ExecCommand(ctx, "ceph", cmd...)


Yes this is much required

Madhu-1 · 2023-09-12T06:58:06Z

internal/csi-addons/networkfence/fencing.go

+				// Evict the client if it matches the CIDR block
+				err := evictCephFSClient(ctx, clientIP, "0")
+				if err != nil {
+					return fmt.Errorf("Error evicting client %s: %s\n", clientIP, err)


start error with small letters ad use %w for wrapping error

Madhu-1 · 2023-09-12T06:59:14Z

internal/csi-addons/networkfence/fencing.go

+			// Check if the clientIP is in the CIDR block
+			if isIPInCIDR(ctx, clientIP, cidr) {
+				// Evict the client if it matches the CIDR block
+				err := evictCephFSClient(ctx, clientIP, "0")


what will happen for already evicted clients? are we going to see any error or it will be skipped?

Should be no-op, that is skip. I can try to test it out.

Madhu-1 · 2023-09-12T06:59:33Z

internal/csi-addons/networkfence/fencing.go

+	// Parse the CIDR block
+	_, ipCidr, err := net.ParseCIDR(cidr)
+	if err != nil {
+		log.DebugLog(ctx, "Error parsing CIDR block %s: %v\n", cidr, err)


use error logging.

Madhu-1 · 2023-09-12T07:00:05Z

internal/csi-addons/networkfence/fencing.go

+	cmd := []string{"tell", fmt.Sprintf("mds.%s", mdsDaemonID), "client", "evict", clientIP}
+	_, stdErr, err := util.ExecCommand(ctx, "ceph", cmd...)


use with timeout as the command might get stuck?

Madhu-1 · 2023-09-12T07:01:45Z

internal/csi-addons/networkfence/fencing.go

+		for _, client := range activeClients {
+			clientIP, err := fetchIP(client.Inst)
+			if err != nil {
+				return fmt.Errorf("Error fetching client IP: %s\n", err)
+			}
+			// Check if the clientIP is in the CIDR block
+			if isIPInCIDR(ctx, clientIP, cidr) {


what if we dont find any activeClients but we still want to blocklist all the IP's in the CIDR?

Thanks @Madhu-1 , updated.
For the IPs in CIDR which doesn't have any corresponding active clients, blocklisting like rbd does -> i.e. blocklisting the entire IP by adding to ceph blocklist.
PTAL.

Madhu-1 · 2023-09-25T07:16:00Z

internal/csi-addons/cephfs/network_fence.go

+/*
+Copyright 2023 The Ceph-CSI Authors.
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+    http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/


it looks like its missing some new lines please check

Madhu-1 · 2023-09-25T07:17:32Z

internal/csi-addons/networkfence/fencing.go

@@ -132,6 +142,134 @@ func (nf *NetworkFence) AddNetworkFence(ctx context.Context) error {
 	return nil
 }

+func listActiveClients(ctx context.Context, mdsRank string) ([]activeClient, error) {


why to pass mdsRank as function argument its hardcoded value 0 always?

Madhu-1 · 2023-09-25T07:20:43Z

internal/csi-addons/networkfence/fencing.go

+		return parts[1], nil
+	}
+
+	return "", errors.New("failed to extract IP address")


return default from which client we failed to fetch IP?

Just for clarity,
Did you mean to return the ID of client in place of empty string in that case?

i mean to return from what we are not able to extra IP address or there should be atleast a log of clientInfo which helps of debugging

Madhu-1 · 2023-09-25T07:21:12Z

internal/csi-addons/networkfence/fencing.go

+		return clientID, nil
+	}
+
+	return 0, errors.New("unable to extract client ID")


any more details we can return in error?

Thanks @Madhu-1, Updated.
Returning the client info too which contains the instance field of client struct, to check the missing format.

riya-singhal31 · 2023-09-25T20:49:40Z

An early review. Please add unit-tests for functions like fetchIP() so that the parsing of the client IP-address is validated.

Thanks @nixpanic, Updated.
PTAL.

nixpanic

Just a few minor things to improve. Generally looks pretty good to me.

internal/csi-addons/networkfence/fencing.go

nixpanic · 2023-09-27T10:59:33Z

internal/csi-addons/networkfence/fencing.go

+		}
+		// if no active client found corresponding to the ip in cidr
+		// blocklisting entire ip
+		if !isFound {


I don't think this is complete yet.

Consider a cidr that contains multiple worker nodes. Maybe a single worker node has an active CephFS client, and was evicted. All other workernodes in that cidr need to be blocklisted.

Instead of isFound as bool, you could create a list of evicted clients, and skip those clients while blocklisting all IP-addresses in the CIDR.

Thanks @nixpanic for the review,
Updated, PTAL.

nixpanic · 2023-09-27T11:03:57Z

internal/csi-addons/networkfence/fencing_test.go

+	}
+
+	for _, tt := range tests {
+		tt := tt


I am not very fond of this. It would be clearer to use tc := tt so that tc is clearly an instance for the text-case. You can then use tc in all calls below.

nixpanic

just needs a few more smaller improvements

nixpanic · 2023-10-02T08:36:59Z

internal/csi-addons/networkfence/fencing.go

+				}
+				log.DebugLog(ctx, "client %d has been evicted\n", clientID)
+				// add the CIDR to the list of blocklisted IPs
+				evictedIPs[cidr] = true


You need to track the singe client IP-address that was evicted, not the whole CIDR block. There might be other IP-addresses in the CIDR block that are not evicted, and those will need to be blocklisted.

Instead of cidr as key in the map, use client.fetchIP().

internal/csi-addons/networkfence/fencing_test.go

nixpanic · 2023-10-02T08:45:14Z

internal/csi-addons/networkfence/fencing.go

+
+	// Parse the stdout to extract blocklist entries
+	// each entry is a separate line in the output
+	entries := strings.Split(strings.TrimSpace(stdout), "\n")


Give an example of the output that is expected from the ceph command. It is difficult to review this without knowing what the command returns.

Even better: move the parsing to a helper function and add a unit-test.

Thanks Niels, have added comments, explaining the workflow here and in main removeClientEviction too, PTAL.

Nothing extra is being done here for parsing, just storing them as new lines. So might not be a need for unit testing.

Everything that can be unit-tested, should ideally be unit-tested 😄

Yes, updated. PTAL 😄

nixpanic · 2023-10-02T08:46:53Z

internal/csi-addons/networkfence/fencing.go

+	// iterate through CIDR blocks and remove matching entries
+	for _, cidr := range nf.Cidr {
+		for _, entry := range blocklistEntries {
+			if strings.HasPrefix(entry, cidr) {


It is difficult to verify how this works. Make it easier for others (and for yourself in a few months time) to understand this by adding comments with examples of what cidr contains, and how enty is formatted.

Thanks @nixpanic , updated. PTAL

A cidr in the format of 127.0.0.1:0/3710147553 is weird...

A CIDR could be 192.168.123.234/16, a blocklisted IP in that range can be 192.168.1.2 (note that the prefix-comparing won't work here). You will need to check if the IP-address from the entry is included in the range of IP-addresses described by the CIDR. At the moment, the current check is not correct.

Thanks @nixpanic ,
Updated.

riya-singhal31 · 2023-10-06T15:14:23Z

Testing:
riyasinghal@rsinghal-mac ceph-csi % kubectl exec -c csi-addons csi-cephfsplugin-provisioner-676758bc76-7fxr4 -n rook-ceph -- csi-addons -operation NetworkFence -clusterid rook-ceph -secret default/csi-cephfs-secret -cidrs 1.1.1.1/32 -endpoint unix:///csi/csi-addons.sock
Network fence successful%

riyasinghal@rsinghal-mac ceph-csi % kubectl exec -c csi-addons csi-cephfsplugin-provisioner-676758bc76-7fxr4 -n rook-ceph -- csi-addons -operation NetworkUnFence -clusterid rook-ceph -secret default/csi-cephfs-secret -cidrs 1.1.1.1/32 -endpoint unix:///csi/csi-addons.sock
Network unfence successful%

PTAL, cc: @nixpanic , @Madhu-1 , @Rakshith-R

nixpanic · 2023-10-10T11:06:25Z

internal/csi-addons/networkfence/fencing.go

+	// iterate through CIDR blocks and remove matching entries
+	for _, cidr := range nf.Cidr {
+		for _, entry := range blocklistEntries {
+			if strings.HasPrefix(entry, cidr) {


A cidr in the format of 127.0.0.1:0/3710147553 is weird...

A CIDR could be 192.168.123.234/16, a blocklisted IP in that range can be 192.168.1.2 (note that the prefix-comparing won't work here). You will need to check if the IP-address from the entry is included in the range of IP-addresses described by the CIDR. At the moment, the current check is not correct.

nixpanic

Looks complete to me. Left a few minor comments that could improve the code a little more.

nixpanic · 2023-10-13T16:09:56Z

internal/csi-addons/networkfence/fencing.go

+	var entries []string
+	for _, line := range lines {
+		if strings.TrimSpace(line) != "" && !strings.HasPrefix(line, "listed") {
+			entries = append(entries, line)


Are complete entry lines used anywhere? If not, you could call fetchIPfromEntry() here and add the IP-address to the []string that is returned.

If that is an option, you could rename getBlocklistEntries() to getBlocklistIPs() and make the code a little simpler.

Thanks, @nixpanic
Updated, PTAL.

nixpanic · 2023-10-13T16:11:23Z

internal/csi-addons/networkfence/fencing.go

+			// fetch IP from entry
+			entryIP, err := fetchIPfromEntry(entry)
+			if err != nil {
+				return fmt.Errorf("error fetching client IP: %w", err)


Consider including the entry contents in the error message (with %q). It'll make troubleshooting and debugging much easier.

Pull request has been modified.

riya-singhal31 · 2023-10-17T06:49:33Z

Looks complete to me. Left a few minor comments that could improve the code a little more.

Thanks @nixpanic , Updated!
Requesting for a re-look.

Madhu-1 · 2023-10-06T10:51:01Z

examples/cephfs/secret.yaml

-  userID: <plaintext ID>
-  userKey: <Ceph auth key corresponding to ID above>
+  userID: admin
+  userKey: AQDY7RNlYlbUGhAASH0UHq8Jn4fvVmGIzsbARQ==

  # Required for dynamically provisioned volumes
-  adminID: <plaintext ID>
-  adminKey: <Ceph auth key corresponding to ID above>
+  adminID: admin
+  adminKey: AQDY7RNlYlbUGhAASH0UHq8Jn4fvVmGIzsbARQ==


Please revert back this changes

Madhu-1 · 2023-10-06T10:52:22Z

internal/csi-addons/cephfs/network_fence_test.go

+// TestFenceClusterNetwork is a minimal test for the FenceClusterNetwork()
+// procedure. During unit-testing, there is no Ceph cluster available, so
+// actual operations can not be performed.
+func TestFenceClusterNetwork(t *testing.T) {
+	t.Parallel()
+
+	controller := NewFenceControllerServer()
+
+	req := &fence.FenceClusterNetworkRequest{
+		Parameters: map[string]string{},
+		Secrets:    nil,
+		Cidrs:      nil,
+	}
+
+	_, err := controller.FenceClusterNetwork(context.TODO(), req)
+	assert.Error(t, err)
+}
+
+// TestUnfenceClusterNetwork is a minimal test for the UnfenceClusterNetwork()
+// procedure. During unit-testing, there is no Ceph cluster available, so actual
+// operations can not be performed.
+func TestUnfenceClusterNetwork(t *testing.T) {
+	t.Parallel()
+	controller := NewFenceControllerServer()
+
+	req := &fence.UnfenceClusterNetworkRequest{
+		Parameters: map[string]string{},
+		Secrets:    nil,
+		Cidrs:      nil,
+	}
+	_, err := controller.UnfenceClusterNetwork(context.TODO(), req)
+	assert.Error(t, err)
+}


what is the benefit we are getting from this unit test?

Not much, bit it should not panic either.

Madhu-1 · 2023-10-06T10:53:05Z

internal/csi-addons/networkfence/fencing.go

+func listActiveClients(ctx context.Context) ([]activeClient, error) {
+	// FIXME: replace the ceph command with go-ceph API in future
+	cmd := []string{"tell", fmt.Sprintf("mds.%s", mdsRank), "client", "ls"}
+	stdout, stdErr, err := util.ExecCommandWithTimeout(ctx, 5*time.Minute, "ceph", cmd...)


RPC timeout is 3 minutes, i would suggest keeping it for 2 minutes or even less.

Yes, will update it.
Apologies for the delay @Madhu-1 , these reviews somehow were not showing up to me before and now its showing 2 weeks ago.
Thanks!

no worries, that's my mistake, i did review but forgot to submit it 🤦🏻

Madhu-1 · 2023-10-06T10:55:28Z

internal/csi-addons/networkfence/fencing.go

+		return parts[1], nil
+	}
+
+	return "", errors.New("failed to extract IP address")


i mean to return from what we are not able to extra IP address or there should be atleast a log of clientInfo which helps of debugging

Madhu-1 · 2023-10-17T06:51:27Z

internal/csi-addons/cephfs/network_fence_test.go

+	"testing"
+
+	"github.com/stretchr/testify/assert"
+


no new line is required

Madhu-1 · 2023-10-17T06:54:01Z

internal/csi-addons/networkfence/fencing.go

+			err = nf.addCephBlocklist(ctx, host, false)
+			if err != nil {
+				return err
+			}


i think this can lead to a problem for below case

Create RBD NetworkFence CR for one IP 10.10.10.10

Created CephFS NetworkFence CR for IP range but above IP comes in the Range

Delete the CephFS Network Fence CR to unblocklist the IP

Now the expectation is the IP that is used in RBD NetworkFence is also blocklisted but that's not the case anyone isn't it?

Yes, that looks possible.

I do not know if it is possible to see if a blocklisted client is CephFS or RBD. If that is returned (or resolvable otherwise) from listing the blocklisted client output, a check for the type can be added. Otherwise, we'll need to com up with some other way of tracking/identifying.

The blocklisted output doesn't have anything to distinguish between two
ex- $ ceph osd blocklist ls
listed 1 entries
127.0.0.1:0/3710147553 2018-03-19 11:32:24.716146

So, one way could be to add a field in NetworkFence struct to track the type of network fence (RBD or CephFS). When creating a NetworkFence object, we can set this field based on the network fence type, and then while evicting we can check if this has only cephfs and not rbd then evict.
WDYT @Madhu-1 , @nixpanic

i dont think we can make any specific change related to cephcsi in the Spec/API. we can decide what to support and what not to support from the cephcsi point. if you are talking about faster recovery of cephfs volume and if that is the whole responsibility of this API you can just document here, use RBD network fence to fence the whole cluster IP and use cephfs network fence to fence any active client which helps to evict only active client, if there are no active client, just return the success or if there any active client in the range just blocklist them and return success. @nixpanic thoughts?

I guess the behavior can be documented as some kind of corner-case. Most workflows will NetweorkFence a node (or whole cluster) for both RBD and CephFS. If there is an issue with the node, neither RBD and CephFS is expected to function. Unfencing one of the protocols suggests the node is expected to be recovered, so both CephFS and RBD are expected to work again too.

We can improve this in a future version of the CSI-Addons Spec, I guess. A NetworkFence operation could pass, and update a NetworkFence.Context, similar to what a PersistentVolume.Context has. In a Kubernetes environment, a NetworkFenceClass might even be appropriate, it could link to secrets and contain driver specific options.

nixpanic · 2023-10-17T10:06:45Z

internal/csi-addons/networkfence/fencing.go

+	return blocklistIPs, nil
+}
+
+func (nf *NetworkFence) removeBlocklistEntry(ctx context.Context, entry string) error {


hmm, is the function really different from removeCephBlocklist() ?

https://github.com/ceph/ceph-csi/blob/devel/internal/csi-addons/networkfence/fencing.go#L178

Maybe the same function can be used?

Right Niels, thanks!
It's the same computation, for the whole un-blocklisting the same logic can be used.

nixpanic · 2023-10-17T10:08:10Z

internal/csi-addons/networkfence/fencing.go

+
+// RemoveClientEviction unblocks access for all the IPs in the IP range mentioned via the CIDR block
+// using a network fence.
+func (nf *NetworkFence) RemoveClientEviction(ctx context.Context) error {


This might be similar a RemoveNetworkFence() from https://github.com/ceph/ceph-csi/blob/devel/internal/csi-addons/networkfence/fencing.go#L202

riya-singhal31 · 2023-10-20T11:26:56Z

Updated the PR with all the reviews,
Please take a look!
@nixpanic , @Madhu-1

Thanks!

nixpanic

Looks good to me, thanks!

Madhu-1

LGTM, one small change is required.

Madhu-1 · 2023-10-23T07:53:52Z

internal/csi-addons/cephfs/network_fence.go

+
+	cr, err := util.NewUserCredentials(req.GetSecrets())
+	if err != nil {
+		return nil, status.Error(codes.Internal, err.Error())


Internal error or invalid? in UnfenceClusterNetwork its Invalid and here its Internal.

Thanks Madhu, should be InvalidArgument, updated. PTAL.

Pull request has been modified.

Madhu-1 · 2023-10-23T08:15:08Z

@riya-singhal31 instead of a new commit, please amend this change to the commit in which this was implemented

riya-singhal31 · 2023-10-23T08:37:35Z

@riya-singhal31 instead of a new commit, please amend this change to the commit in which this was implemented

Done!

nixpanic · 2023-10-24T14:27:32Z

@Mergifyio rebase

this commit adds client eviction to cephfs, based on the IPs in cidr block, it evicts those IPs from the network. Signed-off-by: Riya Singhal <[email protected]>

Signed-off-by: Riya Singhal <[email protected]>

this commit un-blocklists the clients provided in cidr for unfencing operation. Signed-off-by: Riya Singhal <[email protected]>

Signed-off-by: Riya Singhal <[email protected]>

mergify · 2023-10-24T14:27:58Z

rebase

✅ Branch has been successfully rebased

ceph-csi-bot · 2023-10-24T14:29:18Z

/test ci/centos/upgrade-tests-cephfs

ceph-csi-bot · 2023-10-24T14:29:19Z

/test ci/centos/k8s-e2e-external-storage/1.28

ceph-csi-bot · 2023-10-24T14:29:19Z

/test ci/centos/k8s-e2e-external-storage/1.27

ceph-csi-bot · 2023-10-24T14:29:19Z

/test ci/centos/upgrade-tests-rbd

ceph-csi-bot · 2023-10-24T14:29:20Z

/test ci/centos/k8s-e2e-external-storage/1.26

ceph-csi-bot · 2023-10-24T14:29:20Z

/test ci/centos/mini-e2e-helm/k8s-1.28

ceph-csi-bot · 2023-10-24T14:29:20Z

/test ci/centos/mini-e2e-helm/k8s-1.27

ceph-csi-bot · 2023-10-24T14:29:21Z

/test ci/centos/mini-e2e/k8s-1.28

ceph-csi-bot · 2023-10-24T14:29:21Z

/test ci/centos/mini-e2e-helm/k8s-1.26

ceph-csi-bot · 2023-10-24T14:29:21Z

/test ci/centos/mini-e2e/k8s-1.27

ceph-csi-bot · 2023-10-24T14:29:22Z

/test ci/centos/mini-e2e/k8s-1.26

mergify bot added the component/cephfs Issues related to CephFS label Sep 11, 2023

riya-singhal31 changed the title ~~cephfs: Add CSI-Addons NetworkFence support to CephFS~~ [WIP]cephfs: Add CSI-Addons NetworkFence support to CephFS Sep 11, 2023

nixpanic reviewed Sep 11, 2023

View reviewed changes

Madhu-1 requested changes Sep 12, 2023

View reviewed changes

Madhu-1 reviewed Sep 25, 2023

View reviewed changes

riya-singhal31 changed the title ~~[WIP]cephfs: Add CSI-Addons NetworkFence support to CephFS~~ cephfs: Add CSI-Addons NetworkFence support to CephFS Sep 26, 2023

riya-singhal31 requested review from Madhu-1 and nixpanic September 26, 2023 11:25

nixpanic requested changes Sep 27, 2023

View reviewed changes

riya-singhal31 requested a review from nixpanic September 29, 2023 08:57

nixpanic requested changes Oct 2, 2023

View reviewed changes

riya-singhal31 requested a review from nixpanic October 9, 2023 05:46

nixpanic requested changes Oct 10, 2023

View reviewed changes

riya-singhal31 mentioned this pull request Oct 13, 2023

Supporting IPv6 addresses in network fencing procedure for cephFS. #4192

Closed

nixpanic previously approved these changes Oct 13, 2023

View reviewed changes

riya-singhal31 requested a review from nixpanic October 16, 2023 09:02

Madhu-1 reviewed Oct 17, 2023

View reviewed changes

nixpanic reviewed Oct 17, 2023

View reviewed changes

riya-singhal31 requested review from Madhu-1 and nixpanic October 20, 2023 11:17

nixpanic previously approved these changes Oct 20, 2023

View reviewed changes

Madhu-1 reviewed Oct 23, 2023

View reviewed changes

riya-singhal31 requested a review from Madhu-1 October 23, 2023 08:12

Madhu-1 approved these changes Oct 23, 2023

View reviewed changes

Madhu-1 requested a review from nixpanic October 23, 2023 08:39

nixpanic approved these changes Oct 24, 2023

View reviewed changes

riya-singhal31 added 8 commits October 24, 2023 14:27

cephfs: adds the implementation of client eviction

70bf427

this commit adds client eviction to cephfs, based on the IPs in cidr block, it evicts those IPs from the network. Signed-off-by: Riya Singhal <[email protected]>

cephfs: add network fence service to identity.go

1d6acdb

Signed-off-by: Riya Singhal <[email protected]>

cephfs: adding unit test for fetchIP for client eviction

dd2e2bf

Signed-off-by: Riya Singhal <[email protected]>

cephfs: adding unit test for fetchID

4b7e055

Signed-off-by: Riya Singhal <[email protected]>

cephfs: adds unit testing for fencing procedure

45bbcc7

Signed-off-by: Riya Singhal <[email protected]>

cephfs: implement the logic for unfencing procedure

88ae4ac

this commit un-blocklists the clients provided in cidr for unfencing operation. Signed-off-by: Riya Singhal <[email protected]>

cephfs: adds unit testing for unfencing procedure

c00fd9f

Signed-off-by: Riya Singhal <[email protected]>

cephfs: expose FenceControllerServer in driver.go to handle the requests

8d617bc

Signed-off-by: Riya Singhal <[email protected]>

nixpanic added the ok-to-test Label to trigger E2E tests label Oct 24, 2023

ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Oct 24, 2023

mergify bot merged commit 1fc9678 into ceph:devel Oct 24, 2023
24 checks passed

		cmd := []string{"tell", fmt.Sprintf("mds.%s", mdsDaemonID), "client", "evict", clientIP}
		_, stdErr, err := util.ExecCommand(ctx, "ceph", cmd...)

cephfs: Add CSI-Addons NetworkFence support to CephFS #4113

cephfs: Add CSI-Addons NetworkFence support to CephFS #4113

Conversation

riya-singhal31 commented Sep 11, 2023

nixpanic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riya-singhal31 Sep 25, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riya-singhal31 Sep 26, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riya-singhal31 commented Sep 25, 2023

nixpanic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nixpanic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riya-singhal31 commented Oct 6, 2023

Choose a reason for hiding this comment

nixpanic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riya-singhal31 commented Oct 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riya-singhal31 Oct 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riya-singhal31 Oct 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riya-singhal31 commented Oct 20, 2023

nixpanic left a comment

Choose a reason for hiding this comment

Madhu-1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riya-singhal31 Sep 25, 2023 •

edited

Loading

riya-singhal31 Sep 26, 2023 •

edited

Loading

riya-singhal31 Oct 17, 2023 •

edited

Loading

riya-singhal31 Oct 19, 2023 •

edited

Loading