Skip to content

Commit

Permalink
ci: update golangci-lint to v1.60.3
Browse files Browse the repository at this point in the history
- gomnd is replaced by mnd in v1.58.0

Signed-off-by: Praveen M <[email protected]>
  • Loading branch information
iPraveenParihar committed Dec 20, 2024
1 parent 6acc44c commit d750f21
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion build.env
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ GO111MODULE=on
COMMITLINT_VERSION=latest

# static checks and linters
GOLANGCI_VERSION=v1.57.2
GOLANGCI_VERSION=v1.60.3

# external snapshotter version
# Refer: https://github.com/kubernetes-csi/external-snapshotter/releases
Expand Down
8 changes: 4 additions & 4 deletions e2e/rbd_helper.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import (
"k8s.io/kubernetes/test/e2e/framework"
)

//nolint:gomnd // numbers specify Kernel versions.
//nolint:mnd // numbers specify Kernel versions.
var nbdResizeSupport = []util.KernelVersion{
{
Version: 5,
Expand All @@ -48,7 +48,7 @@ var nbdResizeSupport = []util.KernelVersion{
}, // standard 5.3+ versions
}

//nolint:gomnd // numbers specify Kernel versions.
//nolint:mnd // numbers specify Kernel versions.
var fastDiffSupport = []util.KernelVersion{
{
Version: 5,
Expand All @@ -60,7 +60,7 @@ var fastDiffSupport = []util.KernelVersion{
}, // standard 5.3+ versions
}

//nolint:gomnd // numbers specify Kernel versions.
//nolint:mnd // numbers specify Kernel versions.
var deepFlattenSupport = []util.KernelVersion{
{
Version: 5,
Expand All @@ -75,7 +75,7 @@ var deepFlattenSupport = []util.KernelVersion{
// To use `io-timeout=0` we need
// www.mail-archive.com/[email protected]/msg38060.html
//
//nolint:gomnd // numbers specify Kernel versions.
//nolint:mnd // numbers specify Kernel versions.
var nbdZeroIOtimeoutSupport = []util.KernelVersion{
{
Version: 5,
Expand Down
2 changes: 1 addition & 1 deletion internal/cephfs/mounter/volumemounter.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (
var (
availableMounters []string

//nolint:gomnd // numbers specify Kernel versions.
//nolint:mnd // numbers specify Kernel versions.
quotaSupport = []util.KernelVersion{
{
Version: 4,
Expand Down
2 changes: 1 addition & 1 deletion internal/rbd/nodeserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ var (
kernelRelease = ""
// deepFlattenSupport holds the list of kernel which support mapping rbd
// image with deep-flatten image feature
//nolint:gomnd // numbers specify Kernel versions.
//nolint:mnd // numbers specify Kernel versions.
deepFlattenSupport = []util.KernelVersion{
{
Version: 5,
Expand Down
2 changes: 1 addition & 1 deletion internal/rbd/rbd_util.go
Original file line number Diff line number Diff line change
Expand Up @@ -1793,7 +1793,7 @@ func (ri *rbdImageMetadataStash) String() string {
func stashRBDImageMetadata(volOptions *rbdVolume, metaDataPath string) error {
imgMeta := rbdImageMetadataStash{
// there are no checks for this at present
Version: 3, //nolint:gomnd // number specifies version.
Version: 3, //nolint:mnd // number specifies version.
Pool: volOptions.Pool,
RadosNamespace: volOptions.RadosNamespace,
ImageName: volOptions.RbdImageName,
Expand Down
2 changes: 1 addition & 1 deletion scripts/golangci.yml.in
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ linters:
- wrapcheck
# TODO: enable linters added in golangci-lint 1.43
- contextcheck
- gomnd
- mnd
- ireturn
- tagliatelle
- varnamelen
Expand Down

0 comments on commit d750f21

Please sign in to comment.