Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTOR-934-plugin-network-3-com-snmp #5217

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

sfarouq-ext
Copy link
Contributor

Community contributors

Description

Please include a short resume of the changes and what is the purpose of this pull request.
Any relevant information should be added to help reviewers to understand what are the stakes
of the pull request.

Fixes # (issue)
If you are fixing a github Issue already existing, mention it here.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched.
Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.
To integrate this pull request into our core we need to add some automated tests to check the proper
functioning of this PR. Ideally we need the following informations:

  • SNMP: MIB files and full snmpwalk of enterprise branch (snmpwalk -ObentU -v 2c -c public address .1.3.6.1.4.1 > equipment.snmpwalk) or SNMP collections.
  • HTTP API (SOAP, Rest/Json, XML-RPC): the documentation and some curl examples (command with -v + output) or HTTP collections.
  • CLI: command line examples (command + result).
  • SQL: queries + results + column types or SQL collections.
  • JMX: mbean names and attributes.

If some information is confidential, such as logins or IP addresses, obfuscate them in what is sent
publicly and we'll get in touch with you by private message if this information is needed.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • I have provide data or shown output displaying the result of this code in the plugin area concerned.

Centreon team

Description

PLEASE MAKE SURE THAT THE BRANCH PR INCLUDES JIRA TICKET ID

Please include a short resume of the changes and what is the purpose of this pull request.
Any relevant information should be added to help reviewers to understand what are the stakes
of the pull request.

Fixes # (issue)
If you are fixing a github Issue already existing, mention it here.
If you are fixing one or more JIRA ticket, mention it here too.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched.
Provide clear instructions so that it can be correctly tested.
Mention the automated tests included in this FOR (what they test like mode/option combinations).

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@sfarouq-ext sfarouq-ext requested a review from a team as a code owner October 2, 2024 11:07
@sfarouq-ext sfarouq-ext requested a review from a team as a code owner October 2, 2024 11:09
@sfarouq-ext sfarouq-ext requested a review from sdepassio October 2, 2024 11:09
@omercier omercier force-pushed the CTOR-934-plugin-network-3-com-snmp branch 2 times, most recently from 1a8b31f to 682c7db Compare October 21, 2024 07:46
@omercier omercier requested review from a team as code owners October 21, 2024 07:46
@omercier omercier requested review from ddes and kduret October 21, 2024 07:46
@omercier omercier force-pushed the CTOR-934-plugin-network-3-com-snmp branch from 682c7db to 59b4f3f Compare October 21, 2024 07:47
@omercier omercier merged commit f6cd371 into develop Oct 21, 2024
23 checks passed
@omercier omercier deleted the CTOR-934-plugin-network-3-com-snmp branch October 21, 2024 11:45
omercier pushed a commit that referenced this pull request Oct 28, 2024
omercier pushed a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants