Pputman/change package reference #11307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umber The github sha would be a better version number to use than the PR number, as its immutable and follows best practices.
…umber The github sha would be a better version number to use than the PR number, as its immutable and follows best practices. Also eliminates unnecessary junk in the workflow to make it work with both PRs and pushes/merges
…g/celo-monorepo into pputman/change-package-reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggestion to change the artifact upload name to use github.sha instead of the pr number. This will follow best practices and eliminate the need to have extra code to make this workflow run properly in both pr and and push events