Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soloseng/L2-governanceSlasher-test #11280

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Soloseng/L2-governanceSlasher-test #11280

merged 5 commits into from
Dec 3, 2024

Conversation

soloseng
Copy link
Contributor

Description

setup L2 testing framework

Related issues

@soloseng soloseng requested a review from a team as a code owner November 22, 2024 19:40
@soloseng soloseng self-assigned this Nov 22, 2024
@soloseng soloseng changed the title Soloseng//L2-governanceSlasher-test Soloseng/L2-governanceSlasher-test Dec 2, 2024
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Dec 2, 2024 •
edited
Loading

Soloseng/L2-governanceSlasher-test

Generated at commit: 5d26d1d348fd0faad48277bc1fa59463eea802bd

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 3
2
0
14
43
62
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

pahor167
pahor167 reviewed Dec 3, 2024
View reviewed changes
packages/protocol/test-sol/unit/governance/network/GovernanceSlasher.t.sol Outdated
GovernanceSlasherTest_approveSlashing
{}

// contract GovernanceSlasherTest_slash_setup is GovernanceSlasherTest {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the comment ?

@soloseng soloseng enabled auto-merge (squash) December 3, 2024 17:12
@soloseng soloseng merged commit 4591aa1 into release/core-contracts/12 Dec 3, 2024
39 of 42 checks passed
@soloseng soloseng deleted the soloseng/L2-governanceSlasher-test branch December 3, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pahor167 pahor167 pahor167 approved these changes

Assignees

@soloseng soloseng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soloseng @pahor167