[do not merge] Release 11 vs 12 - just to know how much has changed #11035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove references to packages deleted * Remove circleci dockerfiles and workflow * Delete reference to patches folder
Use `master` workload-id-provider pool
* fix & cleanup * fixed resolved field in lock file
* fixed gold token actors * ++ doubleSigningSlasher test * ∆ conflicting function name * set epochSize manually
* adding ignore files for docker files and github * update to use new workflow with security restrictions on container builds * updating 2.0 to 2.1 workflow
* adding ignore files for docker files and github * update to use new workflow with security restrictions on container builds * updating 2.0 to 2.1 workflow * fixing container versions
) * docs(SECURITY): deletes `SECURITY.md` to inherit the default file Maintained in https://github.com/celo-org/.github/blob/main/SECURITY.md --------- Co-authored-by: arthurgousset <[email protected]>
Co-authored-by: Victoria <[email protected]>
* upgrade celo deps from dt repo * remove exchange env test. the Contract is defunkt and mento owns the replacement. no need for a test here * exchange no longer exists so we dont need to freeze or thaw it
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Fee Handler Foundry * adds some tests, getting node-gyp errors so can't test * saving progress * saving progress * fix compiler errors * fix up through distribute test * saving progress * saving progress * fixes a couple tests * removes TODO * get rid of last TODO * add README * deletes old tests * fix build * address README feedback * addresses some feedback * follow revert naming convention * clarify distribute when balance is zero * add event tests * Update packages/protocol/test-sol/common/FeeHandler.t.sol Co-authored-by: soloseng <[email protected]> --------- Co-authored-by: pahor167 <[email protected]> Co-authored-by: soloseng <[email protected]>
* fix: update USDCUSD config * chore: update docker image version Co-authored-by: Nelson Taveras <[email protected]> --------- Co-authored-by: Nelson Taveras <[email protected]> Co-authored-by: Nelson Taveras <[email protected]>
* Load test refactor. Included ordinals loadtest case * Trigger container build * Using maxFeePerGas and maxPriorityFeePerGas for ordinals txs * Fix gas config * Fix linter * Prepare load-test small improvements
* Election up till activate * ElectionValidatorSigners mostly done * ElectionValidatorSigners done * Last test batch missing * All tests are working * removal of election ts tests * compilation CI fix * utils added * constants added * minor refactor * Update packages/protocol/test-sol/voting/Election.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/voting/Election.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/voting/Election.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/voting/Election.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/voting/Election.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/voting/Election.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/voting/Election.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/voting/Election.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/voting/Election.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/voting/Election.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/voting/Election.t.sol Co-authored-by: soloseng <[email protected]> * buildable * PR comments 2 * Missing tests added * Split of the tests --------- Co-authored-by: soloseng <[email protected]>
* test init * deployed successful with correct owner * passing initialize test using a tunnel * passing setMembershipHistoryLength tests * ++ more test * enable skip * ++ constants; more tests; cleanup * ++ address to pubkey helper * stuck on invalid blspop during registration * Pinned submodule to specific tag/commit * ++ more tests * ++ tests * reworked layout + test * ++ affiliate tests * ++ deaffiliate * remove submodule * re add submodule * removed secp256k1 submodule * adding the library directly to repo, as foundry does not build it otherwise * ++ dev note * updated yarn * update contract name * ++ updateEcdsaPublicKey; updatePublicKeys * format * ++ registerValidatorGroup * yarn install * ++deregisterValidatorGroup tests * cleanup * ++ add members tests * comment * ++ removeMember test * cleanup * ++ reorder tests * ++ SetNextCommissionUpdate tests * ++ updateCommission tests * ++ calculateEpochScore tests * ++ calculateGroupEpochScore tests * ++ updateValidatorScoreFromSigner tests * clean up * ++ updateMembershipHistory tests * ++ getMembershipInLastEpoch tests * ++ getEpochSize test * ++ getAccountLockedGoldRequirement tests * ++ passing test * ++ distributeEpochPaymentsFromSigner tests ; ++ forceDeaffiliateIfValidator tests * ++ groupMembershipInEpoch tests * ++ all other tests * revert debug chages to contract * cleanup * Updated `celo-foundry` git module to point to `v0.5.13` branch * ++ suggestions * updated test name format * PR feedback * fixed redundant code
* Batched pending withdrawals * Update packages/protocol/test-sol/governance/voting/LockedGold.t.sol Co-authored-by: soloseng <[email protected]> * PR comments --------- Co-authored-by: soloseng <[email protected]>
* wip * WIP: Failing last test * removed shadowed var * using foundry invariant on pragma ^0.8.0 * working invariant tests * code cleanup * delete js test * added most test for 0.5.13 pragma version as well * following naming convention * re-org files to avoid migration conflict * restricted version to 0.8.0 or above * ++ vs code settings ∆ * PR feedback
* Some tests * addressToPublicKey tests * Authorization tests yet missing * All tests * Move of ReleaseGold.t.sol * removal of truffle test * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Co-authored-by: soloseng <[email protected]> * build fix * PR comments * PR comments 2 * Removal of secp reference * Removal of CI step --------- Co-authored-by: soloseng <[email protected]>
It will be moved to the developer tooling repo as its more used there than here. The one function that is used here has been lined in the place its used.
* Remove codecov status badge * Remove deprecated codecov integration
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Victoria <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Victoria <[email protected]>
…hanging workflow (#10636) Update celo-blockchain version in test, and trigger tests when changing workflow file
* deleted comment * Revert "deleted comment" This reverts commit 2d0da96. * WIP * Finished tests * cleanup * Fixed constants file * small lint * removed ts tests * fixed constants * added day to constant * Rename BlockchainParameters.t.Sol to BlockchainParameters.t.sol * packages/protocol/test-sol/governance/network/BlockchainParameters.t.sol * Check for tests with wrong extensions * Fixed tests * lint * fixed broken test * bad comment * naming * Reformatting and tests * Removed ganache test job from the CI * Delete packages/protocol/test-sol/fail.t.sol * fail with wrong extension * More rename and lint * More formatting * cleanup * renamed SortedListedLink mock * more renaming * Delete packages/protocol/test-sol/common/fail.SOl * Moved ElectionMock * Moving more staff around * Rolled back mock election * typo * Changed LinkedList name * Delete packages/protocol/test-sol/common/Integration.t.sol * Refactor Registry * Fix multisig * fix * typos * pr comments * version update * foundry config update * foundry version hardcoded * test fix --------- Co-authored-by: pahor167 <[email protected]>
* Release: Sorted oracles update (#10891) * Sorted oracles update * integration test fixes * constants added * Update packages/protocol/contracts/stability/SortedOracles.sol Co-authored-by: Martín Volpe <[email protected]> * Removal of Mento reference * Update packages/protocol/test-sol/stability/SortedOracles.t.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test-sol/stability/SortedOracles.t.sol Co-authored-by: soloseng <[email protected]> * PR comments * Equivalent tokens on top of updated sorted oracles (Based of CR10) (#10904) * Brought changes from https://github.com/celo-org/celo-monorepo/pull/10895/files#diff-ba272032c5f1b7e89d5777b3c886685b581324bdf22733ee272e2790f5d631df * Fuzzy added --------- Co-authored-by: pahor167 <[email protected]> * prettify fix --------- Co-authored-by: Martín Volpe <[email protected]> Co-authored-by: soloseng <[email protected]> * FeeCurrency Adapter (#10907) * FeeCurrency Adapter * PR comments * Format documents * gitmodules * submodules added * solidity version fix * OZ contracts same commit as master * Revert "OZ contracts same commit as master" This reverts commit 8d8f2d6. * OZ to same commit as master * Getter&Setter for wrapped token * Proxy added * split of FeeCurrencyAdapter * prettier fix * refactor * Update packages/protocol/test-sol/stability/FeeCurrencyAdapter.t.sol Co-authored-by: Martín Volpe <[email protected]> * PR comments * PR comments * Decimals + Total supply added * Update packages/protocol/contracts-0.8/stability/FeeCurrencyAdapter.sol * Update packages/protocol/contracts-0.8/stability/FeeCurrencyAdapter.sol * Trigger * Wrapper reference removed * interface added --------- Co-authored-by: Martín Volpe <[email protected]> Co-authored-by: Tim Moreton <[email protected]> Co-authored-by: alvarof2 <[email protected]> * Calculation of unlockable gold (#10731) * Fix for historical vote records * contractkit fix * lint fix * Governance version update * PR comments * extended test * Remove console.log * Test * lint fix * version fix * version fix --------- Co-authored-by: Martín Volpe <[email protected]> * Gas Price Minimum should never be zero (#10909) * GasPriceMinimum backward compatibility fix (#10922) * Update Dockerfiles (#10915) * Remove references to packages deleted * Remove circleci dockerfiles and workflow * Delete reference to patches folder * Update workload-id-provider in metadata-crawler-build job (#10916) Use `master` workload-id-provider pool * fix ganache dependency resolution (#10917) * fix & cleanup * fixed resolved field in lock file * test * Tooling fix * lint fix * revert of gas price minimum * Update packages/protocol/lib/compatibility/ast-code.ts Co-authored-by: Martín Volpe <[email protected]> --------- Co-authored-by: Javier Cortejoso <[email protected]> Co-authored-by: soloseng <[email protected]> Co-authored-by: Martín Volpe <[email protected]> * Storage gap for FeeCurrencyAdapter (#10933) Storage gap * Debit 0 value check (#10930) * Removal of SortedOracle multiplier (#10931) * Removal of SortedOracle multiplier * removal of comment * Make super of FeeCurrencyAdapterOwnable.sol explicit (#10944) * Added note to FeeCurrencyAdapter.sol initializer (#10943) * FeeAdapter debit round up (#10940) * Round up of debit * PR comments * Code quality post audit (#10945) Code quality * SortedOracles sourced from Mento core for CR10 (#10946) * SortedOracles sourced from Mento core * PR comments * Update gap size to follow 50 rule (#10948) * CR11 fix verification (#10951) * Force AddressSortedLinkedListWithMedian library redeploy for CR11 * CI fix * PR comments * yarn lock * Updates specification of SrotedOracles (#10970) * Update Natspec for FeeAdapter (#10969) * dockerfile --------- Co-authored-by: Martín Volpe <[email protected]> Co-authored-by: soloseng <[email protected]> Co-authored-by: Tim Moreton <[email protected]> Co-authored-by: alvarof2 <[email protected]> Co-authored-by: Javier Cortejoso <[email protected]>
* ++ @celo/dev-utils to dev dependencies * - updated to use CR 11 instead of 10 - removed general test * Bump lockedGold contract version * revert version ∆ * removed unused env var * bump contract versions
* L2 migration infra * refactor * refactor
* Add top level NatSpec * Celo -> CELO * Add note about naming --------- Co-authored-by: Martín Volpe <[email protected]>
* removed L2 duplicated test code * -- compiltation warning * Removed duplicated L2 election test code ### Description Using test contract inheritance to minimize duplicated code during L2 testing ### Other changes removed unused var ### Tested unit tested ### Related issues - Fixes #[issue number here] ### Backwards compatibility _Brief explanation of why these changes are/are not backwards compatible._ ### Documentation _The set of community facing docs that have been added/modified because of this change_ * Revert "Removed duplicated L2 election test code" This reverts commit b0058c5. * -- duplicate test * Remove unnecessary comment * Add whitespace --------- Co-authored-by: Marcin Chrzanowski <[email protected]>
* removed L2 duplicated test code * -- compiltation warning * Removed duplicated L2 election test code ### Description Using test contract inheritance to minimize duplicated code during L2 testing ### Other changes removed unused var ### Tested unit tested ### Related issues - Fixes #[issue number here] ### Backwards compatibility _Brief explanation of why these changes are/are not backwards compatible._ ### Documentation _The set of community facing docs that have been added/modified because of this change_ * Revert "Removed duplicated L2 election test code" This reverts commit b0058c5. * basic L2 setup * -- duplicate * -- duplicate test * moved whenL2 to utils * uncommented validator test * -- duplicate call * Remove unnecessary comment * Add whitespace * Add missing whitespace --------- Co-authored-by: Marcin Chrzanowski <[email protected]>
* removed L2 duplicated test code * -- compiltation warning * Removed duplicated L2 election test code ### Description Using test contract inheritance to minimize duplicated code during L2 testing ### Other changes removed unused var ### Tested unit tested ### Related issues - Fixes #[issue number here] ### Backwards compatibility _Brief explanation of why these changes are/are not backwards compatible._ ### Documentation _The set of community facing docs that have been added/modified because of this change_ * Revert "Removed duplicated L2 election test code" This reverts commit b0058c5. * basic L2 setup * -- duplicate * -- duplicate test * moved whenL2 to utils * uncommented validator test * initial test working * -- duplicate call * passing L2 validators test * Remove unnecessary comment * Add whitespace * Add missing whitespace * Fix whitespace * Remove unnecessary registry set EpochManager is already set in the Registry in setupEpochManager. * Remove unnecessary inherit Utils already inherits from TestConstants * Propagate error from Validators tunnel * Move setCommissionUpdateDelay to own test contract * Move setDowntimeGracePeriod to own test contracts * Move registerValidator L2 test to own test contract * Fix test contract name * Move L1 NoBls test to separate test contract * Use L2 helper for NoBls_L2 test * Fix log absence check * Split Affiliate test into L1/L2 test contracts * Split deaffiliate tests into L1/L2 contracts * Remove test case already covered by L2 test contract * Split updatePublicKeys into L1/L2 contracts * Remove duplicated test case * Split updateBlsPublicKey into L1/L2 contracts * Remove test case already covered by L2 contract * Split updateCommission test into L1/L2 contracts * Split CalculateEpochScore into L1/L2 contracts * Split calculateGroupEpochScore test into L1/L2 contracts * Split updateValidatorScoreFromSigner into L1/L2 contracts * Split getMemebershipInLastEpoch into L1/L2 contracts * Remove test case covered by L2 contract * Split getTopGroupValidatorsAccounts into L1/L2 contracts * Split distributeEpochPaymentFromSigner into L1/L2 test contracts * Split mintStableToEpochManager into L1/L2 contracts * Split forceDeaffiliateIfValidator into L1/L2 contracts * Add L2 test contract for groupMembershipInEpoch * Remove test case covered by L2 contract * Create L2 test contract for resetSlashingMultiplier * Create L2 test contract for resetSlashingMultiplier * Remove unnecessary whenL2 * Remove test cases covered by L2 test contracts * Split setValidatorScoreParameters into L1/L2 test contracts * Fix typo * Remove unnecessary inheritance TransitionToL2AfterL1 already inherits from ValidatorsTest. * Use helper function * Remove unnecessary function call * Remove unnecessary imports * Import IsL2Check directly * Add a V2 version of PrecompilesOverride * Use getEpochNumber logic from PrecompileOverride * Set up Registry and EpochManager in Utils * Use new util contract for L2 transition in Validators * Use WhenL2 in Election test --------- Co-authored-by: Marcin Chrzanowski <[email protected]>
* running all tests in L2 * using registry from utils * using WhenL2 utils contract
* -- duplicated function * general L2 tests * ++ L1 GovernanceTest_resetHotfix * ++ remaining tests * debuging * more debug logs * revert debug logs * change inheritance order * renaming of contract * PR feedback * -- commented code * -- unused imports * using WhenL2 utils contract * separate L2 tests for functions that revert on L2 * PR feedback
passing proposal L2 test
* Passing test using registry from utils * most L2 test passing * using _setup contract * -- L2 duplicates
* passing test using utils * setup all L2 test
* ++ L2 setup; renamed local registry contract; passing L1 test * ++ left over tests * PR feedback
reworked CeloToken test
* initial tests * fixed EpochRewardsTest_getRewardsMultiplier_L2 tests * using whenL2 utils contract * removed duplicated test * fixed rest of failing tests * renamed function
* renamed utils contract * capitalize
* added L2 testing * updated filename
* -- console logs * passing L1 test using Utils contract * updated filename * Passing L2 test * -- duplicate test
* Passing L1 test using TestWithUtils * passing L2 tests * -- unused contract * -- commented line
* Update delegation when slashing * tests fixed * PR comments * lint
* ++ events * PR feedback * updated & fixed tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?
Other changes
Describe any minor or "drive-by" changes here.
Tested
An explanation of how the changes were tested or an explanation as to why they don't need to be.
Related issues
Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.
Documentation
The set of community facing docs that have been added/modified because of this change