Skip to content
This repository has been archived by the owner on Dec 7, 2018. It is now read-only.

Add :Async option to detach connections and handle in separate actors #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chewi
Copy link

@chewi chewi commented Apr 20, 2018

The change looks big but it's mostly just moving methods from the Server class to the new Handler class. I've only given it a quick try last thing on a Friday but it seems to work well. I could possibly add some tests next week if required.

@chewi
Copy link
Author

chewi commented Apr 23, 2018

I've realised I need to terminate the actors I'm creating on each request but adding terminate to the end of async_on_connection doesn't seem to do anything and even if I manually terminate actors from a console, they seem to still sit in the thread list. 😞

@chewi
Copy link
Author

chewi commented Apr 23, 2018

Never mind, I figured it out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant