revert fix: Prevent redis task loss when closing connection while in poll

[thuibr]

No description provided.

[Nusnus]

Hey, thank you for the fix.
Can you please explain what and why is the change please?
Also, please add unit tests.

Lastly, we can mark this as draft for now and ready again after the above is answered & the CI fully passes.

Thanks!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.48%. Comparing base (1691d3e) to head (b6eea5f).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2154      +/-   ##
==========================================
+ Coverage   81.47%   81.48%   +0.01%     
==========================================
  Files          77       77              
  Lines        9500     9507       +7     
  Branches     1148     1148              
==========================================
+ Hits         7740     7747       +7     
  Misses       1569     1569              
  Partials      191      191              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thuibr]

Hi @Nusnus I was trying to debug #1785 but this doesn't do it. I will follow your guidance once I find a fix.

[thuibr]

@Nusnus this now reverts #1733 because that causes bugs for #1785.

[thuibr]

I also don't really understand the rationale in #1733. Why would completing a BRPOP re-enqueue a message in redis?

[thuibr]

Alternatively, I could see setting socket_timeout to something by default instead of None, which also fixes the issue.

app.conf.broker_transport_options = {'socket_timeout': 5}