Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(manifest): remove unneeded directives #1713

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stegayet
Copy link
Contributor

@stegayet stegayet commented May 12, 2023

Cleaning before #1705.

Description

This PR removes unneeded directives in MANIFEST.in file, cf. https://packaging.python.org/en/latest/guides/using-manifest-in/.

Exclude directives have also been removed and instead added to .gitignore as they are compiled Python files or docs build artifacts.

How this has been tested ?

Used the following script to check sdist content diff between both versions:

git checkout main
python setup.py sdist
tar -tvf dist/kombu-5.3.0b3.tar.gz > old_archive_content.txt
git checkout chore/clean-manifest-file
python setup.py sdist
tar -tvf dist/kombu-5.3.0b3.tar.gz > new_archive_content.txt
diff new_archive_content.txt old_archive_content.txt > diff.txt

The last command returns nothing.

@stegayet stegayet force-pushed the chore/clean-manifest-file branch from 7f6ddd3 to 4e11e07 Compare May 12, 2023 13:47
@stegayet stegayet changed the title chore(manifest): remove uneeded directives chore(manifest): remove unneeded directives May 12, 2023
@stegayet stegayet force-pushed the chore/clean-manifest-file branch from 4e11e07 to 229e4df Compare May 12, 2023 13:51
@stegayet stegayet marked this pull request as ready for review May 12, 2023 13:52
@auvipy auvipy self-requested a review May 13, 2023 00:14
@Nusnus Nusnus self-requested a review May 13, 2023 20:14
@stegayet stegayet force-pushed the chore/clean-manifest-file branch from 229e4df to 28617e8 Compare May 14, 2023 13:53
include THANKS
include TODO
include setup.cfg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to check them properly before merge/remove them

@stegayet stegayet force-pushed the chore/clean-manifest-file branch from 28617e8 to 0947381 Compare May 15, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants