Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the sum method for vclVector objects #115

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

daydreamt
Copy link

Dear Mr Determan, thank you for your efforts with gpuR!

While using it I noticed there is no sum() method for vclVectors, so I went ahead and added one, based on the one for vclMatrix. Please let me know if I can do anything more, or differently, to get it merged.

@codecov-io
Copy link

Codecov Report

Merging #115 into develop will decrease coverage by 0.15%.
The diff coverage is 7.69%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #115      +/-   ##
===========================================
- Coverage    81.39%   81.23%   -0.16%     
===========================================
  Files           58       58              
  Lines        12399    12424      +25     
===========================================
+ Hits         10092    10093       +1     
- Misses        2307     2331      +24
Impacted Files Coverage Δ
R/wrappers-vclVector.R 44.44% <0%> (-14.1%) ⬇️
R/methods-vclVector.R 71.34% <100%> (+0.08%) ⬆️
src/vienna_stats.cpp 72.96% <8.33%> (-1.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6527e8...7edb41c. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 81.238% when pulling 7edb41c on daydreamt:develop into b6527e8 on cdeterman:develop.

@cdeterman
Copy link
Owner

Thanks for the contribution! If you could, I would appreciate you adding the unit tests as well for the new method. Given that sum is part of the Summary generic I would say add this to the tests/testthat/test_cpu_vclVector_math.R and tests/testthat/test_vclVector_math.R files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants