-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dx: Add additional hooks to pre-commit #7
base: 202449-pre-commit
Are you sure you want to change the base?
Conversation
Added an implementation of the |
Added an initial version of a Noticed an existing config in Also probably needs some more attention around which files to exclude, in accordance with the |
Added an implementation of the |
b531f46
to
41003ee
Compare
|
|
Reimplements `make check-amount-access` for Python regex.
Also intends to replace `make check-src-include-order` and `make check-hdr-include-order` by adding configuration to check for include ordering.
Reimplements `make check-discouraged-functions` for Python regex.
Includes default config file and an initial word list to ignore.
e5560cd
to
3265aea
Compare
Grabbed the list of "scopes" from top level directory organization, along with a sane perusal of the commit messages from the last few months. Needs some auditing. This hook utilization requires running |
Adds additional hooks to
pre-commit
.shellcheck
hook.make check-amount-access
as a localpygrep
hook.clang-format
hook to fail on suggestion warnings with additional configuration to sort includes.make check-discouraged-functions
as a localpygrep
hook.Adding this PR (along with future hooks to come) against your PR for now, until ElementsProject#7884 is merged.