-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ASt ophys
pipeline
#30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ast_ophys_pipeline
src/tye_lab_to_nwb/ast_ophys/extractors/cnmfe_matlab_segmentationextractor.py
Show resolved
Hide resolved
Overall looks good! A few minor comments above |
CodyCBakerPhD
approved these changes
Sep 28, 2023
Thank you @CodyCBakerPhD for the review! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
MiniscopeConverter
to acquisition(480, 752)
while this AVI is(240, 376)
-> added to processingnwbfile.processing["ophys"]["OnePhotonSeriesProcessed"]
nwbfile.processing["ophys"]["OnePhotonSeriesMotionCorrected"]
C6-J588_Disc5_timestampsAllCumulData.mat
C6J588_Disc5_msCamComb_MC_curated_20220605_1722.mat
(+ link issue, first the neuron struct has to be saved into a new Matlab file to be able to open in Python)the sampling rate for the processed data is the same as the raw and segmented data of 15.0 (it shows up in OpenCV as 30.0 but that corresponds to a playback speed and not the actual rate.)
The nwbinspector returns
PYNWB_VALIDATION
forMiniscope
device, the issue for reference: NeurodataWithoutBorders/pynwb#1777