Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASt ophys pipeline #30

Merged
merged 24 commits into from
Sep 28, 2023
Merged

Add ASt ophys pipeline #30

merged 24 commits into from
Sep 28, 2023

Conversation

weiglszonja
Copy link
Collaborator

@weiglszonja weiglszonja commented Sep 26, 2023

Checklist:

  • Add raw Miniscope data using MiniscopeConverter to acquisition
  • Add interface for processed Miniscope data ("C6-J588_Disc5_msCamAll_ffd.mat"): the raw Miniscope video snippets are concatenated together into a single .avi file. The first frames of every trial is removed. Note that the raw Miniscope video shape (height, width) is (480, 752) while this AVI is (240, 376) -> added to processing nwbfile.processing["ophys"]["OnePhotonSeriesProcessed"]
  • Add extractor and interface for the motion corrected Miniscope data ("C6-J588_Disc5_msCamComb_MC"): the processed Miniscope data was motion corrected and saved as a MATLAB file. -> added to processing
    nwbfile.processing["ophys"]["OnePhotonSeriesMotionCorrected"]
  • Add trials from C6-J588_Disc5_timestampsAllCumulData.mat
  • Add custom mat file with CNMFE segmentation data C6J588_Disc5_msCamComb_MC_curated_20220605_1722.mat (+ link issue, first the neuron struct has to be saved into a new Matlab file to be able to open in Python)
  • Upload prototype data

the sampling rate for the processed data is the same as the raw and segmented data of 15.0 (it shows up in OpenCV as 30.0 but that corresponds to a playback speed and not the actual rate.)

  • Confirm sampling rate of processed data which is 30.0 when the video is opened in OpenCV (raw data, segmented data is fps 15.0)
  • Double check timestamps are adjusted correctly
  • Add metadata
  • Add convert_all_sessions script after the single session convert script is finalized
  • Rerun stub conversion from fresh environment and fix requirements file for missing packages
  • Run nwbinspector on fully converted data

The nwbinspector returns PYNWB_VALIDATION for Miniscope device, the issue for reference: NeurodataWithoutBorders/pynwb#1777

@weiglszonja weiglszonja marked this pull request as draft September 26, 2023 14:22
@weiglszonja weiglszonja marked this pull request as ready for review September 28, 2023 13:03
@CodyCBakerPhD
Copy link
Member

Overall looks good!

A few minor comments above

@weiglszonja
Copy link
Collaborator Author

Thank you @CodyCBakerPhD for the review! 🚀

@CodyCBakerPhD CodyCBakerPhD merged commit 4f48faf into main Sep 28, 2023
@CodyCBakerPhD CodyCBakerPhD deleted the add_ast_ophys_pipeline branch September 28, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants