-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SegmentationExtractor #366
Open
pauladkisson
wants to merge
32
commits into
0.6.0
Choose a base branch
from
segmentation
base: 0.6.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
986f264
renamed neuropil --> background
pauladkisson 0362270
removed channels and num_planes
pauladkisson 575fac8
renamed imagingextractor_mixin to imaging_extractor_mixin
pauladkisson 0483635
removed channels
pauladkisson 0aa7d8d
renamed imagingextractor_mixin to imaging_extractor_mixin
pauladkisson 9ed3179
fixed bug with all None roi_responses
pauladkisson 372fb8e
corrected _image_masks typo
pauladkisson 0c11101
added initial tests and refactored segmentation extractor to use abst…
pauladkisson 4bf2630
removed write_segmentation
pauladkisson 21a8240
updated get_background_pixel_masks
pauladkisson 116ddfb
removed properties from numpysegmentationextractor
pauladkisson b7a4411
reordered segmentation methods
pauladkisson 28af405
split background response from roi responses
pauladkisson e135ffe
added some tests
pauladkisson e6e2e4b
added background_image_masks to numpyseg
pauladkisson 232db7f
finished simple tests (w/o parameterization)
pauladkisson 9daf8b7
fixed bug with num_background
pauladkisson 367cc7b
refactored numpysegmentationextractor
pauladkisson 7199605
extracted different init modes into separate fns
pauladkisson 468e91a
updated docstring
pauladkisson 809fda1
extracted get_default_roi_locations_from_image_masks to extraction_tools
pauladkisson 8d8733c
extracted get_roi_indices to base segmentation clas
pauladkisson 5c4005d
reordered methods to match base
pauladkisson 76f325c
added tests for get_roi_indices
pauladkisson 24de1fe
added parameterization for test
pauladkisson b3d9352
added parameterization for test
pauladkisson bf8b546
flattened parameterization
pauladkisson b031781
fixed typo
pauladkisson cbd1691
added tests fromFile
pauladkisson 64aac0e
added TODO
pauladkisson fedb4bd
added frame_slice
pauladkisson 2dd85af
get_args for compound types
pauladkisson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used? Is it needed? I think generally
None
is used in typehinting to express theNone
type