Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal alignment #9

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Temporal alignment #9

merged 4 commits into from
Dec 11, 2024

Conversation

pauladkisson
Copy link
Member

@pauladkisson pauladkisson commented Dec 9, 2024

@pauladkisson pauladkisson changed the base branch from main to epoch December 9, 2024 16:29
Copy link
Contributor

@alessandratrapani alessandratrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so you are not aligning the interfaces using temporally_align_data_interfaces in the converter, but directly passing the video_timestamps_file_paths to the interface. Correct?

Base automatically changed from epoch to main December 11, 2024 16:38
@pauladkisson
Copy link
Member Author

Ok, so you are not aligning the interfaces using temporally_align_data_interfaces in the converter, but directly passing the video_timestamps_file_paths to the interface. Correct?

That's right. I felt that temporally_align_data_interfaces was a bit clunky in this case bc I would have to update its signature to take a file_path, which would then require overwriting run_conversion, so handling it in the interfaces seemed more attractive.

@pauladkisson pauladkisson merged commit 6b90324 into main Dec 11, 2024
1 check failed
@pauladkisson pauladkisson deleted the temporal_alignment branch December 11, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants