Feature: Highlight and Enlarge points #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janithwanni
force-pushed
the
feat/highlight-enlarge-points
branch
from
a05cf48 to
9872622
Compare
janithwanni
force-pushed
the
feat/highlight-enlarge-points
branch
from
9872622 to
b393221
Compare
|
Hi @casperhart, I finally managed to clean up all the PRs with demos. This PR introduces,
The demo is located at
|
janithwanni
commented
Nov 5, 2024
Comment on lines
+244
to
+247
| force_rerender <- function(proxy) { | ||
| proxy$session$sendCustomMessage("clear-enlarge", list(id = proxy$id)) | ||
| return(proxy) | ||
| } |
There was a problem hiding this comment.
Additional function to call render on the scene
| #' | ||
| #' @param proxy proxy object created by \code{\link{display_scatter_proxy}} | ||
| #' @param point_list Numeric vector. indexes to highlight in the prinary dataset | ||
| #' @param alpha The transparency value of the points outside of the point_list |
There was a problem hiding this comment.
The alpha parameter points towards the alpha of the points outside because the points given by the id list will have an alpha of 1
| @@ -1,5 +1,5 @@ | |||
| export const VERTEX_SHADER_2D = ` | |||
| uniform float size; | |||
| attribute float size; | |||
There was a problem hiding this comment.
I made changes to the vertex shader to be able to change the size as an attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #122
Changes:
enlarge_pointsandhighlight_pointsthrough a proxyclear_*to clear points, edges, highlights and enlarge through a proxy