Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plan): add missing paymentProviders field and update options data… #92

Closed
wants to merge 1 commit into from

Conversation

MonishK2002
Copy link
Contributor

… type

Description

This PR addresses the following issues in the Plan entity of the Java Casdoor SDK:

  • Added: The missing paymentProviders field, which is required to match the Golang implementation. This field is defined as a String[] in the Golang code.
  • Updated: The data type of the options field to String[], ensuring compatibility with the expected data types in the Golang codebase.

Changes Made

  • Introduced a new field public String[] paymentProviders; in the Plan class.
  • Changed the data type of the options field to `public String[] options;.

Related Issue

This PR addresses the mismatch between the Java and Golang implementations regarding the Plan entity.

Please review the changes and let me know if there are any suggestions or concerns.

… type

### Description
This PR addresses the following issues in the `Plan` entity of the Java Casdoor SDK:

- Added: The missing `paymentProviders` field, which is required to match the Golang implementation. This field is defined as a `String[]` in the Golang code.
- Updated: The data type of the `options` field to `String[]`, ensuring compatibility with the expected data types in the Golang codebase.

### Changes Made
- Introduced a new field `public String[] paymentProviders;` in the `Plan` class.
- Changed the data type of the `options` field to `public String[] options;.

### Related Issue
This PR addresses the mismatch between the Java and Golang implementations regarding the `Plan` entity.

Please review the changes and let me know if there are any suggestions or concerns.
@casbin-bot
Copy link

@tangyang9464 @imp2002 please review

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2024

CLA assistant check
All committers have signed the CLA.

@MonishK2002
Copy link
Contributor Author

@tangyang9464
Hi Casdoor Team,
I have raised a pull request that addresses the following issues in the Plan entity of the Java Casdoor SDK:

    I added the missing paymentProviders field, which is required to match the Golang implementation. This field is defined as a String[] in the Golang code.
   I have updated the data type of the options field to String[], ensuring compatibility with the expected data types in the Golang codebase.
 The pull request has been merged successfully. However, I noticed that the new version including these changes has not been released yet. Could you please release a new version of the Java Casdoor SDK that includes these updates?

Thank you for your assistance and for providing such a valuable tool.

@hsluoyz
Copy link
Member

hsluoyz commented Oct 14, 2024

Replaced by: 9361a85

@hsluoyz hsluoyz closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants