Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): marking notification as read when deleting distributed reliability #887

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Sotatek-TungNguyen2a
Copy link
Collaborator

@Sotatek-TungNguyen2a Sotatek-TungNguyen2a commented Dec 26, 2024

Description

We mark notifications as read once we have deleted them, or we are done processing them if they are not user facing.

A notification can only be marked once, or it will return 404.

It’s possible that we mark it as read, and crash before deleting the notification in the local database of the wallet.

When we try to delete again, we will hit this 404 error.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: 1597

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

@Sotatek-TungNguyen2a Sotatek-TungNguyen2a self-assigned this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant