feat(core): marking notification as read when deleting distributed reliability #887
+22
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We mark notifications as read once we have deleted them, or we are done processing them if they are not user facing.
A notification can only be marked once, or it will return 404.
It’s possible that we mark it as read, and crash before deleting the notification in the local database of the wallet.
When we try to delete again, we will hit this 404 error.
Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Security
Code Review