Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): long running operation recovery #882

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

Sotatek-TungNguyen2a
Copy link
Collaborator

@Sotatek-TungNguyen2a Sotatek-TungNguyen2a commented Dec 23, 2024

Description

If we are recovering, any operations that were on-going must be recovered.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: DTIS-1583

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

@Sotatek-TungNguyen2a Sotatek-TungNguyen2a self-assigned this Dec 23, 2024
@Sotatek-TungNguyen2a Sotatek-TungNguyen2a changed the title feat(core0: long running operation recovery feat(core): long running operation recovery Dec 23, 2024
@@ -93,8 +93,15 @@ class IpexCommunicationService extends AgentService {
);
}

if (grantNoteRecord.linkedRequest) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this function we are storing a pending connection twice:

if (grantNoteRecord.linkedRequest) {
  await this.operationPendingStorage.save({
    id: grantNoteRecord.linkedRequest.current,
    recordType: OperationPendingRecordType.ExchangeReceiveCredential,
  });
}

and:

const pendingOperation = await this.operationPendingStorage.save({
  id: op.name,
  recordType: OperationPendingRecordType.ExchangeReceiveCredential,
});

is there a case where grantNoteRecord.linkedRequest.current and op.name are the same? we should avoid creating the pendingOperation twice if so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants