-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): long running operation recovery #882
Open
Sotatek-TungNguyen2a
wants to merge
13
commits into
develop
Choose a base branch
from
feat/DTIS-1583-long-running-operation-recovery
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(core): long running operation recovery #882
Sotatek-TungNguyen2a
wants to merge
13
commits into
develop
from
feat/DTIS-1583-long-running-operation-recovery
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic-record-to-mark-restore-as-complete
…ic-record-to-mark-restore-as-complete
…ic-record-to-mark-restore-as-complete
…ic-record-to-mark-restore-as-complete
Sotatek-TungNguyen2a
requested review from
jimcase and
iFergal
as code owners
December 23, 2024 08:15
Sotatek-TungNguyen2a
changed the title
feat(core0: long running operation recovery
feat(core): long running operation recovery
Dec 23, 2024
jimcase
reviewed
Dec 23, 2024
@@ -93,8 +93,15 @@ class IpexCommunicationService extends AgentService { | |||
); | |||
} | |||
|
|||
if (grantNoteRecord.linkedRequest) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this function we are storing a pending connection twice:
if (grantNoteRecord.linkedRequest) {
await this.operationPendingStorage.save({
id: grantNoteRecord.linkedRequest.current,
recordType: OperationPendingRecordType.ExchangeReceiveCredential,
});
}
and:
const pendingOperation = await this.operationPendingStorage.save({
id: op.name,
recordType: OperationPendingRecordType.ExchangeReceiveCredential,
});
is there a case where grantNoteRecord.linkedRequest.current
and op.name
are the same? we should avoid creating the pendingOperation twice if so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we are recovering, any operations that were on-going must be recovered.
Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Security
Code Review