Ignore if redfish fails to logout #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redfish sometimes fails to logout after scraping the data and this end up generating the metric redfish_collector_failed that trigger prometheus alerts that can be noise. This can be a BMC problem that might not be properly closing sessions. For more info see: DMTF/python-redfish-library#160 Closes: canonical#76
gabrielcocenza
requested review from
Pjack,
aieri,
samuelallan72,
jneo8,
rgildein and
chanchiwai-ray
Pjack
reviewed
Jul 18, 2024
jneo8
requested changes
Jul 18, 2024
- warning message if fails
gabrielcocenza
changed the title
|
I don't know what's the best choice, if redfish can't logout properly, in the long run it will still cause issue like this canonical/hardware-observer-operator#136 |
Pjack
approved these changes
Jul 26, 2024
jneo8
approved these changes
Jul 26, 2024
aieri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redfish sometimes fails to logout after scraping the data and this end up generating the metric
redfish_collector_failedthat trigger prometheus alerts that can be noise for production clouds.This can be a BMC problem that might not be properly closing sessions.
For more info see:
DMTF/python-redfish-library#160
Closes: #76