Add L2TP support #114
Open
Add L2TP support #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
======================================
Coverage 100% 100%
======================================
Files 36 36
Lines 4131 4260 +129
======================================
+ Hits 4131 4260 +129
Continue to review full report at Codecov.
|
cyphermox
suggested changes
Dec 5, 2019
src/parse.c
Outdated
| @@ -1624,6 +1631,22 @@ const mapping_entry_handler tunnel_def_handlers[] = { | |||
| */ | |||
| {"key", YAML_NO_NODE, handle_tunnel_key_mapping}, | |||
| {"keys", YAML_NO_NODE, handle_tunnel_key_mapping}, | |||
|
|
|||
| /* l2tp; reuses tunnel.local_ip and tunnel.remote_ip*/ | |||
| {"local_tunnel_id", YAML_SCALAR_NODE, handle_netdef_guint, NULL, netdef_offset(l2tp.local_tunnel_id)}, | |||
There was a problem hiding this comment.
Names for keys are typically split with hyphen rather than underscore. Could you please adjust that so things are at least consistent in that regard?
There was a problem hiding this comment.
Oh, how could I miss that.
Done.
stappersg
reviewed
Dec 26, 2019
slyon
added
enhancement
slyon
added
the
community
|
Would be great to have this long awaiting feature 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds L2TP support.
Rework of #82
Checklist
make checksuccessfully.make check-coverage).