Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for top border color on iOS #180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nodonisko
Copy link
Contributor

@Nodonisko Nodonisko commented Dec 4, 2024

PR Description

It is possible to customize border color of tab bar on iOS now.

How to test?

Screenshots

Simulator Screenshot - iPhone 16 Pro - 2024-12-04 at 18 54 43

Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: 9612726

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Nodonisko Nodonisko force-pushed the feat/add-ios-border-color branch from f714239 to 9612726 Compare December 4, 2024 19:31
Copy link
Collaborator

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

But I'm not sure about this prop. I don't want the interface of TabView to become bloated with too many props. Maybe we can define a tabBarStyle prop that will have a limited amount of available properties that people can set. In this case it would be:

<TabView tabBarStyle={{ borderColor: 'red'  }} /> 

This way we will follow JS bottom tabs spec and don't end up in 20 props that people need to set on the root component. You are also setting borderColor to shadowColor Shoudn't this be a separate prop?

Also, did you check if this is possible on Android?

@Nodonisko
Copy link
Contributor Author

I think adding property just for styles is good idea, but in that case should we move also other color styling properties under this new one?

It should be possible for Android but it won't be that easy as for iOS since by default Android doesn't have any border. Not sure why it's called shadow on iOS because in my opinion it looks like standart border.

@okwasniewski
Copy link
Collaborator

@Nodonisko the rest of color styling match JS Bottom Tabs so I don't think thats necessary.

We can start off with only having this style available for iOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants