Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check your email page flickers #12969

Merged
merged 17 commits into from
Jan 2, 2024
Merged

fix: check your email page flickers #12969

merged 17 commits into from
Jan 2, 2024

Conversation

WongChoice
Copy link
Contributor

@WongChoice WongChoice commented Dec 30, 2023

What does this PR do?

Fixes the verify email flicker by making sure the values of both verify_email_page_body and check_your_email are loaded without their default values

Fixes.12966.mp4

Fixes #12966

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link

vercel bot commented Dec 30, 2023

@WongChoice is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Dec 30, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work labels Dec 30, 2023
@WongChoice WongChoice changed the title fixes : check your email page flickers i18n fix : check your email page flickers i18n Dec 30, 2023
Copy link
Contributor

github-actions bot commented Dec 30, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@WongChoice WongChoice changed the title fix : check your email page flickers i18n fix: check your email page flickers i18n Dec 30, 2023
PeerRich
PeerRich previously approved these changes Dec 31, 2023
@PeerRich PeerRich enabled auto-merge (squash) December 31, 2023 19:09
@WongChoice WongChoice changed the title fix: check your email page flickers i18n fix: check your email page flickers Dec 31, 2023
auto-merge was automatically disabled January 1, 2024 16:27

Head branch was pushed to by a user without write access

@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Jan 1, 2024
@WongChoice
Copy link
Contributor Author

@PeerRich hi i was attempting to deploy it in vercel through that 14 days trial unfortunately i did it through this same pull.
please have a re-review thanks.

@WongChoice WongChoice requested a review from PeerRich January 1, 2024 16:44
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Udit-takkar Udit-takkar enabled auto-merge (squash) January 2, 2024 07:03
Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 9:32am

@Udit-takkar Udit-takkar merged commit ffefb34 into calcom:main Jan 2, 2024
16 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗️ .env changes contains changes to env variables Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-2848] i18n: check your email page flickers i18n
3 participants