Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add nav bar #9

Merged
merged 2 commits into from
Jan 11, 2024
Merged

[feat] add nav bar #9

merged 2 commits into from
Jan 11, 2024

Conversation

jinkang-0
Copy link
Collaborator

@jinkang-0 jinkang-0 commented Jan 11, 2024

What's new?

  • Updated template nav bar to match design
    • Includes scripts to update style once scrolled
    • Scripts for menu collapse commented; awaiting mobile design
  • Added font-weight: 400 to h5 in _global.scss

image

Linear Task

https://linear.app/hack-for-impact-2024/issue/HFI-11/nav-bar

@jinkang-0 jinkang-0 force-pushed the jinkang/hfi-11-nav-bar branch from e67d72e to 42233aa Compare January 11, 2024 00:15
Copy link
Contributor

@allisonhongberkeley allisonhongberkeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jinkang-0 jinkang-0 merged commit d5519f5 into main Jan 11, 2024
2 checks passed
oahnh pushed a commit that referenced this pull request Jan 11, 2024
* update navbar, h5 global style

* update navbar height
jinkang-0 added a commit that referenced this pull request Jan 12, 2024
* feat(faq): adds faq section

* [feat] add button component (#8)

* add graphics, button

* update global button style

* update button styles

* [feat] add nav bar (#9)

* update navbar, h5 global style

* update navbar height

* [feat] add footer (#12)

* add footer

* remove edit to env.d.ts

* use astro image for optimization

* remove edit to env.d.ts

* [feat] add hero section (#11)

* update hero

* update text styles, minor adjustment to hero layout

* remove changes to env.d.ts

* tell prettier to ignore env.d.ts

* tell lint to ignore env.d.ts

* update scroll behavior and padding

* microscopic edits

* add bouncing arrow

* add padding-top to Contact section (#14)

* fix(types): moves question type definition to FAQDropdown component

* [feat] create about section (Our Vision, The Mission) (#13)

* create skeleton

* change div to section

* fill out Our Mission + Vision

* add and use b

* clean up / remove comments

* check style (prettier)

* remove b from global styles

* create div for mission and vision

* feat(faq): adds faq section

* fix(types): moves question type definition to FAQDropdown component

* refactor: addresses review comments

* refactor(faq): adjusts container width, updates keydown functionality

---------

Co-authored-by: Jinkang Fang <[email protected]>
Co-authored-by: ccatherinetan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants